Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Authentication - password requirements #926

Open
jordy2254 opened this issue Mar 31, 2024 · 1 comment
Open

User Authentication - password requirements #926

jordy2254 opened this issue Mar 31, 2024 · 1 comment
Labels
API Related to the backend api server written in Go discussion Raises questions that are up for discussion feature A new idea or feature UI Related to the frontend web ui written in Javascript

Comments

@jordy2254
Copy link
Member

Is your feature request related to a problem? Please describe.
With #918 & #828 and off various other discussions it has been identified that there is a requirement for password a password policy which will allow an admin to set a series of rules for the password to be verified against.

Describe the solution you'd like
At a high level this feature should implement a PasswordPolicy struct which contains options for the following;

  • PasswordLength
  • MinSpecialCharacters
  • MinLowerChars
  • MinUpperChars
  • MinDigits

Implementing these features will allow an admin to define a policy for password complexity that a user must follow. This should be stored in the database and a check done on the setting of user passwords before encryption to ensure that it meets the current policy. We could do more here which is open for discussion such as enforcing policies at login so if a change to the policy has been made if on login the user's password doesn't match the requirements they will be made to change it.

@jordy2254 jordy2254 added API Related to the backend api server written in Go UI Related to the frontend web ui written in Javascript labels Mar 31, 2024
@kkovaletp
Copy link
Contributor

Nice catch! This is definitely a useful feature request!
However, while such password complexity rules are very popular, they also produce difficult-to-remember passwords, while such passwords not always crypto-strong enough.
I think that we should not write the code of such a validator for sure, and instead use a well-known, trusted by experts, and popular in the dev community library.
As our final goal here is to make sure that the password is strong enough, I'd ask you to look at something like go-password-validator - we can choose something else, this is just an example of the concept.

@kkovaletp kkovaletp added discussion Raises questions that are up for discussion feature A new idea or feature labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Related to the backend api server written in Go discussion Raises questions that are up for discussion feature A new idea or feature UI Related to the frontend web ui written in Javascript
Projects
None yet
Development

No branches or pull requests

2 participants