NOT FOR MERGE rebuild photoview image #910
Conversation
…ting invalid. And use zoom:1 to show the global map.
…: reimplemented the docker-compose user setup to enhance product setup experience and cover much more cases.
Add missing labels
…mple.yml, as it is defined in the Dockerfile; optimized Dockerfile combining all RUN directives of PROD stage into 1, which will produce single layer and save some space; added Dockerfile-dev, docker-compose-dev.yml, and new "dev" and "dev-down" directives into Makefile, which allows to setup development env in Docker. Instructions of how to use it are in comments at the beginning of Dockerfile-dev and docker-compose-dev.yml files
Video playback starts faster in browsers.
… so that the image could be later run with non-root permissions and the app still be able to do needed operations in the FS
…` target and enhanced comments in the Makefile; commented out the `docker system prune -f` with the comment about the command and why it is there; added optional and commented by default `7zz` commands to the `backup` section of the Makefile
…om locally available source code using lates available dependencies
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #910 +/- ##
==========================================
- Coverage 57.34% 56.78% -0.57%
==========================================
Files 196 197 +1
Lines 15607 15837 +230
Branches 533 533
==========================================
+ Hits 8950 8993 +43
- Misses 6408 6595 +187
Partials 249 249
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I've just merged PR #874 to this branch to fix failing tests |
|
Any ideas why I might be getting errors like this? I'm running |
strange... no ideas. I tested the build on kubuntu 22.04 (amd64) and everything was working fine. |
docker-compose.example.yml
Outdated
| BUILD_DATE: $(date +%Y-%m-%d) | ||
| REACT_APP_BUILD_DATE: $(date +%Y-%m-%d) | ||
| COMMIT_SHA: $(git rev-parse --short HEAD) | ||
| REACT_APP_BUILD_COMMIT_SHA: $(git rev-parse --short HEAD) |
There was a problem hiding this comment.
This solved my issue here. Thanks!
| BUILD_DATE: $(date +%Y-%m-%d) | |
| REACT_APP_BUILD_DATE: $(date +%Y-%m-%d) | |
| COMMIT_SHA: $(git rev-parse --short HEAD) | |
| REACT_APP_BUILD_COMMIT_SHA: $(git rev-parse --short HEAD) | |
| BUILD_DATE: $$(date +%Y-%m-%d) | |
| REACT_APP_BUILD_DATE: $$(date +%Y-%m-%d) | |
| COMMIT_SHA: $$(git rev-parse --short HEAD) | |
| REACT_APP_BUILD_COMMIT_SHA: $$(git rev-parse --short HEAD) |
There was a problem hiding this comment.
Thanks, I tested it and it works for me. Have no idea why it was working with 1 $ before...
I've pushed this change to the repo
|
I've merged here PR #917 with an improvement to thumbnail creation for video files. |
|
I decided to add the My main intention is to provide you with all the info about the product's security level, so you can self-host it with an adequate level of protection and isolation. But also, it would be great if these reports could trigger some new PRs from our community developers with updated dependencies to fix at least already patched ones. Please note that the Grype report about the image contains components from the product, as well as from the base Docker image, which means that we can fix only the vulnerabilities from the product, while we rely on the base image maintainers to keep that image up-to-date and that is why I recommend to periodically rebuild your Photoview image even if there are no new updates here in the repo. |
|
I've merged here PR #918, which adds the change password functionality to the settings page of non-admin accounts |
|
As the project is back to active development, no new merges are expected in this PR. |
…MERGE-rebuild-photoview-image # Conflicts: # api/scanner/scanner_album.go # docker-compose.example.yml
kkovaletp
added
invalid
|
If you're still waiting for some fixes and improvements, not merged into the |
This PR is not for merging.
It is created as a workaround for the fact that the project is on hold, so the image on the Docker Hub was built a long time ago, which leads to some bugs and vulnerabilities not being fixed in the base image and installed 3rd-party components.
With this PR anyone could easily rebuild the Photoview image locally based on the project source code and the latest available 3rd-party components according to the dependencies defined in the project.
See the README in this PR for the step-by-step guide. Here is the copy of the guide for your convenience:
cd <path to the folder on your server, where you expect to host the Photoview internal data>git clone https://github.com/kkovaletp/photoview.git .git checkout NOT-FOR-MERGE-rebuild-photoview-imagegit pulldocker-compose.example.ymlandexample.envfiles and remove theexamplefrom their names (so, you need to have.envanddocker-compose.ymlfiles).Makefilein a text editor and read them. Modify where needed according to the documentation comments to properly match your setup. It is better to go through the files in the next order:.env,docker-compose.yml, andMakefile.makeinstalled in your system or don't want to use it for the Photoview management activities, you could use the same commands from theMakefileand run them in your shell directly, or create your own scripts. Make sure to apply or replace the variables from your.envfirst in this case.Makefileis provided just for your convenience and simplicity, but is optional.Makefile):If the endpoint or the port hasn't been changed in the
docker-compose.ymlfile, Photoview can now be accessed at http://localhost:8000