Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darktable is out of date on edge docker image #935

Closed
vbabiy opened this issue Apr 23, 2024 · 6 comments · Fixed by #863
Closed

Darktable is out of date on edge docker image #935

vbabiy opened this issue Apr 23, 2024 · 6 comments · Fixed by #863
Labels
dependencies Pull requests that update a dependency file docker Related to deployment with Docker scanner Related to the scanner component
Projects

Comments

@vbabiy
Copy link

vbabiy commented Apr 23, 2024

Can we get an updated release with an updated darktable, the latest version is 4.6.1

https://software.opensuse.org/download.html?project=graphics:darktable&package=darktable

The version that photo view ships with doesn't support the new sony cameras.

@vbabiy vbabiy added the bug Something isn't working label Apr 23, 2024
@kkovaletp
Copy link
Contributor

As you can see in the Dockerfile, we don't specify any version for the darktable package, which means that the latest available in the Debian repo version is installed.
As soon as the newer version is added to the repo and we rebuild an image, it should automatically appear in it.

@kkovaletp
Copy link
Contributor

Actually, after some deeper investigation, I was able to install the latest Darktable version into the Photoview image and I'll update my PR #863 with the fix, so once it gets merged, this issue should be solved

kkovaletp pushed a commit to kkovaletp/photoview that referenced this issue Apr 23, 2024
…ed to the dedicated Darktable's repo to install the latest released version, as asked in photoview#935; switched Watchtower to labels instead of profiles
@viktorstrate viktorstrate linked a pull request Apr 24, 2024 that will close this issue
@vbabiy
Copy link
Author

vbabiy commented Apr 28, 2024

Until #863 is merged the docker image is not useable for newer cameras, I get only white boxes and no images like those described in #757

@kkovaletp
Copy link
Contributor

Until #863 is merged the docker image is not useable for newer cameras, I get only white boxes and no images like those described in #757

Unfortunately, this is how open-source projects work: we're not getting money from it and contributing for fun in our free time, so we need to wait for the code review process to complete (in particular, when all other project maintainers including the repo owner will review it with at least owner's approval), and it will happen when there is a free time slot for them.

Until that if you don't want to wait, you could fork the PR and build the image from it locally in the same way, it is configured in #910.

@kkovaletp kkovaletp added scanner Related to the scanner component dependencies Pull requests that update a dependency file docker Related to deployment with Docker and removed bug Something isn't working labels Apr 29, 2024
@kkovaletp kkovaletp added this to To do in Roadmap via automation Apr 29, 2024
@kkovaletp kkovaletp moved this from To do to In progress in Roadmap Apr 29, 2024
viktorstrate pushed a commit that referenced this issue May 15, 2024
* Fix #862, address #826 and maybe some other tickets: reimplemented the docker-compose user setup to enhance product setup experience and cover much more cases.

* make unique DB container name and use it in communication from Photoview

* Removed unnecessary healthcheck for photoview from docker-compose.example.yml, as it is defined in the Dockerfile; optimized Dockerfile combining all RUN directives of PROD stage into 1, which will produce single layer and save some space; added Dockerfile-dev, docker-compose-dev.yml, and new "dev" and "dev-down" directives into Makefile, which allows to setup development env in Docker. Instructions of how to use it are in comments at the beginning of Dockerfile-dev and docker-compose-dev.yml files

* Set RWX permissions to the application's working folder for any user, so that the image could be later run with non-root permissions and the app still be able to do needed operations in the FS

* Enhanced the "Getting started" section in the readme; added the `help` target and enhanced comments in the Makefile; commented out the `docker system prune -f` with the comment about the command and why it is there; added optional and commented by default `7zz` commands to the `backup` section of the Makefile

* Use `slim` base image for final photoview image

* Implement SQLite support according to the PR #851

* Removed deprecated `version` line from compose files; optimized dockerfile to build with less layers and run as non-root; mapped only Photoview related services to Watchtower by default instead of updating all running images on a host; added template for Postgres to the .env; reverted compose executable definition, so the new compose is called when present; added a tip about `lnav` to help

* fix a typo in the username; add support of PostgreSQL; split and optimize backup target in Makefile

* Fixed some typos and styling in Readme, excluded dev-environment setup from the PR; added a list of tips on how to secure Photoview in the Advanced setup section of Readme

* Implemented many security improvements, suggested by @Omar007, switched to the dedicated Darktable's repo to install the latest released version, as asked in #935; switched Watchtower to labels instead of profiles

* forgot the compose file

* move face models back to /app folder; comment out and document unnecessary vars in compose; fix a typo in a few vars

* Exclude Makefile in the root folder from git; documented multiple mounts case better; fixed incorrect SQLite DB path

* Fixed several bugs after complete testing cycle with all 3 DBs

* removed hardcoded port in Dockerfile

* Pin the major version for the `photoview` image for stability

* Revert back to the port 80 inside the container on product owner's request

* Provide a minimal compose file and update the readme accordingly

* Handle incorrect media file and folder permissions; set correct permissions for storage folder; fix healthcheck command for postgres

---------

Co-authored-by: Konstantin Koval <kkb@ukr.net>
Roadmap automation moved this from In progress to Done May 15, 2024
@vbabiy
Copy link
Author

vbabiy commented May 16, 2024

has the docker edge image been updated?

@kkovaletp
Copy link
Contributor

has the docker edge image been updated?

I'm not sure, but the master was.
Make sure to read the Getting Started section of Readme to set it up correctly, as the old config is not compatible with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Related to deployment with Docker scanner Related to the scanner component
Projects
Development

Successfully merging a pull request may close this issue.

2 participants