Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate werkzeug.contrib.cache #1249

Closed
lepture opened this issue Feb 4, 2018 · 6 comments
Closed

Deprecate werkzeug.contrib.cache #1249

lepture opened this issue Feb 4, 2018 · 6 comments
Assignees

Comments

@lepture
Copy link
Contributor

lepture commented Feb 4, 2018

Werkzeug should definitely remove cache from itself. Werkzeug is designed for WSGI application. It seems cache has nothing to do with WSGI itself.

One certain decision in discussion Remove unnecessary crud from werkzeug.contrib would be removing cache. We could release next version with a deprecated warning, and remove it totally in version 1.0.

There are lots of issues to solve, we need to focus on the important things. We can't make a good cache library within werkzeug.

Any feedbacks? @pallets/devteam-werkzeug

@lepture
Copy link
Contributor Author

lepture commented Feb 4, 2018

I'm closing issues related to cache.

@pallets/devteam-werkzeug please re-open it if you find the issue to be very important.

@davidism
Copy link
Member

We had an empty repository called werkzeug-cache that we created because someone wanted to work on it years ago. No commits were ever made, so I deleted it at the end of last year. You can recreate that if you want, we can come up with a more clever name later.

@davidism
Copy link
Member

It would be good to reach out to the Flask-Caching maintainers to help support this.

@lepture
Copy link
Contributor Author

lepture commented Sep 13, 2018

Flask-Caching has ported werkzeug.contrib.cache:

https://github.com/sh4nks/flask-caching/tree/master/flask_caching/backends

@davidism
Copy link
Member

I'm going to disable the caching tests for now, it's causing too much uncertainty with other PRs.

@davidism
Copy link
Member

The tests have been disabled, and instantiating a cache class shows a deprecation warning, "Werkzeug cache is deprecated as of version 0.15 and will be removed in 1.0."

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants