Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for SASL authentication in MemcachedCache, fixed FormParser bug, added support for python-binary-memcached #236

Closed
wants to merge 3 commits into from
Closed

Added support for SASL authentication in MemcachedCache, fixed FormParser bug, added support for python-binary-memcached #236

wants to merge 3 commits into from

Conversation

txbm
Copy link

@txbm txbm commented Dec 12, 2012

Support Additions:

  • Memcached SASL auth
  • Python binary memcached library

Bug fixes:

  • Modified a FormParser test that was failing on account of a bad assertion

@frewsxcv
Copy link

It'd be nice if we could get this merged. Those of use who use SASL are forced to use pylibmc directly

@untitaker untitaker force-pushed the master branch 2 times, most recently from 8377106 to 1842d71 Compare August 31, 2014 00:23
untitaker
untitaker reviewed Sep 2, 2014
View reviewed changes
werkzeug/contrib/cache.py
"""

def __init__(self, servers=None, default_timeout=300, key_prefix=None):
def __init__(self, servers=None, default_timeout=300, key_prefix=None, username=None, password=None):

This comment was marked as off-topic.

Sign in to view

@untitaker
Copy link
Contributor

Hey @petermelias! I know it has been a long time, but if you're still interested in this PR, please rebase against latest master (the testsuite has changed quite drastically since then) and check out the inline comments i've made.

You can remove commits with git rebase -i master.

@txbm
Copy link
Author

txbm commented Sep 2, 2014

I'll take care of it straight away. Thanks for getting a chance to review
it. I can't wait to get it merged.
On Sep 2, 2014 6:54 AM, "Markus Unterwaditzer" notifications@github.com
wrote:

Hey @petermelias https://github.com/petermelias! I know it has been a
long time, but if you're still interested in this PR, please rebase against
latest master (the testsuite has changed quite drastically since then) and
check out the inline comments i've made.

You can remove commits with git rebase -i master.

—
Reply to this email directly or view it on GitHub
#236 (comment).

@untitaker untitaker mentioned this pull request Sep 24, 2014
Closed
@untitaker untitaker force-pushed the master branch 2 times, most recently from f9d0f4e to cbec4d1 Compare October 27, 2014 17:40
@untitaker
Copy link
Contributor

@petermelias Any update on this?

@txbm
Copy link
Author

txbm commented May 14, 2015

@untitaker Wow sorry I completely lost track of this. I had started to implement your suggestions then got side-tracked. I'll try to get it taken care of before the end of the month.

@untitaker untitaker added waiting and removed waiting labels Mar 29, 2016
@lepture
Copy link
Contributor

lepture commented Feb 4, 2018

Close it via #1249

@lepture lepture closed this Feb 4, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@txbm @frewsxcv @untitaker @lepture