Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RedisCache.clear() should not invoke Redis_client.keys #1069

Closed
gdmello opened this issue Feb 13, 2017 · 1 comment
Closed

RedisCache.clear() should not invoke Redis_client.keys #1069

gdmello opened this issue Feb 13, 2017 · 1 comment

Comments

@gdmello
Copy link

gdmello commented Feb 13, 2017 •
edited

Issue:
werkzeug.contrib.cache.RedisCache.clear() invokes Redis_client.keys(..)
The KEYS command is not recommended for production usage.

Python: 2.7.6
Werkzeug: Latest version

Proposal:
Update the clear method to use the recommended 'SCAN' command of redis.

If there is agreement on this feature - I can attempt a patch.
@spacewander spacewander mentioned this issue Aug 19, 2017
Closed
@lepture
Copy link
Contributor

lepture commented Feb 4, 2018

close it via #1249

@lepture lepture closed this as completed Feb 4, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lepture @untitaker @gdmello