Cache timeout tests often fail. #1361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. We currently use virtual machine as CI environment. It runs too slowly, causing timeout-related tests to fail easily. will we consider using docker as CI environment? 2. We can set the cache item's timeout to a large value.Since we have `fast_sleep`, don't worry about waiting for a long time until cache item expired.
|
|
|
We're aware of this. We've tried to fix this multiple times. I have some plans but for now I just rerun the tests when I notice it. |
|
There are some cache tests that can't use |
|
The good solution could be #1249 |
|
Closing this since we're not going to be maintaining the cache contrib. I'm going to disable tests for now so they don't cause problems with other PRs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slowly, causing timeout-related tests to fail easily. will we consider
using docker as CI environment?
fast_sleep, don't worry about waiting for a long time until cache itemexpired.