Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pairtools parsing engine abstraction #156

Open
agalitsyna opened this issue Nov 9, 2022 · 1 comment
Open

pairtools parsing engine abstraction #156

agalitsyna opened this issue Nov 9, 2022 · 1 comment

Comments

@agalitsyna
Copy link
Member

agalitsyna commented Nov 9, 2022

Premise:

  • pysam is fast but introduces multiple logistic complications. We may want to replace it with manual bam parser (Anton's style). pysam:
    • is complicated to link in isolated environments
    • leads to pairtools compilation errors without installing cython before pairtools
    • is not supported on osx
    • is not supported for python 3.11
  • New alignment formats emerge that can be parsed by pairtools with minor modifications, e.g. paf (pafpy)

Proposal:

Introduce an abstraction for parsing engine that can input data from APIs from different tools

Possible technical solutions:

  1. Make a universal wrapper class for "alignment" and create an io library for parsing it from data with different engines

  2. ?

Complications:

  1. Each new engine introduces a new dependency that we want to make optional
@nvictus
Copy link
Member

nvictus commented Nov 9, 2022

What if the API were based on dataframes, instead of abstract alignment records?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants