Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor snipping to enable trans, inter-arm, etc pileups #475

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
71d7e1b
new faster expected full in sandbox
sergpolly Aug 17, 2022
fa58ad2
working expected_full_fast, updated example notebook
sergpolly Sep 21, 2022
15c5d79
Merge branch 'master' into oe-update
sergpolly Sep 21, 2022
b058b25
fix OE generator after bad conflict resolve
sergpolly Sep 22, 2022
3dab5a5
minimize diff
sergpolly Sep 22, 2022
8878c26
typo fix
sergpolly Sep 22, 2022
959d520
refactor snipping to enable trans-pileups
sergpolly Jan 15, 2024
86c2b0a
update snipping tests, test values with allclose
sergpolly Jan 15, 2024
ee7937c
add resuable fixture to snip-test, typo fix
sergpolly Jan 15, 2024
611225b
Merge remote-tracking branch 'origin/oe-update' into bleeding-edge-sv
sergpolly Jan 16, 2024
ef48b14
Merge remote-tracking branch 'origin/refactor-snipping' into bleeding…
sergpolly Jan 16, 2024
9dd14df
let go of pandas<2 requirement
sergpolly Jan 16, 2024
1c1d917
enforce multiprocess-dill (#478)
sergpolly Jan 16, 2024
ba58e96
pandas>2 groupby observed behavior in expected (#480)
sergpolly Jan 17, 2024
598e126
obey new pandas indexing reqs - switch to python-tuples
sergpolly Jan 17, 2024
0c79756
obey new pandas indexing reqs - switch to python-tuples (#481)
sergpolly Jan 17, 2024
d4d10e3
add saddle_stack by dist, deprecate plotting (#483)
sergpolly Jan 19, 2024
c3b3878
Enable futures (#485)
sergpolly Jan 20, 2024
39d4dfd
flake8 to pyproject-ruff, ran ruff format
sergpolly Jan 24, 2024
c8a6f0a
enable arbitrary cis region, remove padding code
sergpolly Jan 26, 2024
d1851b4
Merge branch 'bleeding-edge-sv' into refactor-snipping
sergpolly Jan 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions cooltools/api/expected.py
Original file line number Diff line number Diff line change
Expand Up @@ -319,12 +319,12 @@ def make_diag_tables(clr, regions, regions2=None, clr_weight_name="weight"):
bins = clr.bins()[:]
if clr_weight_name is None:
# ignore bad bins
sizes = dict(bins.groupby("chrom").size())
sizes = dict(bins.groupby("chrom", observed=True).size())
bad_bin_dict = {
chrom: np.zeros(sizes[chrom], dtype=bool) for chrom in sizes.keys()
}
elif is_cooler_balanced(clr, clr_weight_name):
groups = dict(iter(bins.groupby("chrom")[clr_weight_name]))
groups = dict(iter(bins.groupby("chrom", observed=True)[clr_weight_name]))
bad_bin_dict = {
chrom: np.array(groups[chrom].isnull()) for chrom in groups.keys()
}
Expand Down