Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run compatibility tests on arm64 with actuated #4994

Merged
merged 14 commits into from Mar 19, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Feb 29, 2024

Following open-telemetry/community#1954, this is using the actuated self-hosted runners provided by the CNCF to run the compatibility tests on the ARM architecture.

This doesn't update the compatibility matrix yet, the intent is to have the new tests running for a couple weeks to ensure their stability before we commit to a public change.

@dmathieu dmathieu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 29, 2024
@dmathieu dmathieu force-pushed the actuated branch 5 times, most recently from d751541 to 8484f60 Compare February 29, 2024 13:34
@dmathieu dmathieu changed the title Try running compatibility tests on arm64 with actuated Run compatibility tests on arm64 with actuated Feb 29, 2024
@dmathieu dmathieu marked this pull request as ready for review February 29, 2024 13:39
@MrAlias
Copy link
Contributor

MrAlias commented Feb 29, 2024

Can you add a "playbook" for troubleshooting this? It would be ideal if have documentation about how this is run and how to handle failures.

@dmathieu dmathieu force-pushed the actuated branch 3 times, most recently from b880297 to 48e02e5 Compare February 29, 2024 16:23
@dmathieu
Copy link
Member Author

The usage is very basic (the runs-on attribute is all there is, actuated then handles the machine, there is no direct access to it), and is describe in https://actuated.dev/blog/arm-ci-cncf-ampere.
There's also a slack workspace that we can get invited into.

So I wonder if it's worth having specific documentation in this repository. Maybe that should rather be in the community repository (I'm happy to open it there).

cc @atoulme

@atoulme
Copy link

atoulme commented Feb 29, 2024

Probably a great idea to have a small doc on the community repository and link it from your build instructions. We have been learning a fair amount since the start of the engagement. Other teams also are on different adoption curves on this so they'd all benefit.

@XSAM
Copy link
Member

XSAM commented Feb 29, 2024

Could we have a doc (maybe on https://github.com/open-telemetry/community) to present a best practice for using actuated service on github action? By making it a standard for supporting ARM, all teams can use the same snippet code and have a uniform playbook to handle exceptions.

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use tagged version otherwise the CI may become unstable after a new major release of a GitHub Action.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@dmathieu
Copy link
Member Author

dmathieu commented Mar 1, 2024

I have started adding documentation on the community repository: open-telemetry/community#1983

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@alexellis
Copy link

I have updated the compatibility matrix. Actuated doesn't seem to communicate on which linux distribution they use in their runners, so I'm happy to change it to Linux rather than Ubuntu if that seems better.

We use Ubuntu 22.04 at present. You can simply create a job at any time and run cat /etc/os-release if you are ever curious 🙂

@pellared
Copy link
Member

pellared commented Mar 12, 2024

@dmathieu I think it is worth adding a mention in the changelog. WDYT?

EDIT: E.g. something like "Add ARM64 platform to the compatibility testing suite". I am waiting for your feedback before clicking the "merge" button.

@dmathieu dmathieu removed the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 12, 2024
@dmathieu
Copy link
Member Author

I have added a changelog entry. However, I also think we should wait for open-telemetry/community#1983 to be merged, so we can link to that doc.

@dmathieu dmathieu changed the title Run compatibility tests on arm64 with actuated [Do Not Merge Yet] Run compatibility tests on arm64 with actuated Mar 12, 2024
@dmathieu dmathieu changed the title [Do Not Merge Yet] Run compatibility tests on arm64 with actuated Run compatibility tests on arm64 with actuated Mar 19, 2024
@dmathieu
Copy link
Member Author

With the community PR being merged, this PR is ready to go!
I have added a link to the community doc as well.

@MrAlias MrAlias merged commit ca5bb1f into open-telemetry:main Mar 19, 2024
27 checks passed
@alexellis
Copy link

Thanks @dmathieu !

@dmathieu dmathieu deleted the actuated branch March 20, 2024 08:55
@MrAlias MrAlias added this to the v1.25.0 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants