Skip to content

Commit

Permalink
Run compatibility tests on arm64 with actuated (#4994)
Browse files Browse the repository at this point in the history
* try running compatibility tests on arm64 with actuated

* try nested matrix

* setup vmmeter

* try less cpu and less gb with actuated

* add comment about vmmeter

* Update .github/workflows/ci.yml

Co-authored-by: Robert Pająk <pellared@hotmail.com>

* Update .github/workflows/ci.yml

Co-authored-by: Robert Pająk <pellared@hotmail.com>

* Update .github/workflows/ci.yml

Co-authored-by: Robert Pająk <pellared@hotmail.com>

* Update .github/workflows/ci.yml

Co-authored-by: Robert Pająk <pellared@hotmail.com>

* Update .github/workflows/ci.yml

* update compatibility matrix

* use linux name for arm builds

* add changelog entry

* add link to actuated doc

---------

Co-authored-by: Robert Pająk <pellared@hotmail.com>
  • Loading branch information
dmathieu and pellared committed Mar 19, 2024
1 parent 77d9192 commit ca5bb1f
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 10 deletions.
25 changes: 15 additions & 10 deletions .github/workflows/ci.yml
Expand Up @@ -108,17 +108,22 @@ jobs:
strategy:
matrix:
go-version: ["~1.22.0", "~1.21.3"]
os: [ubuntu-latest, macos-latest, windows-latest]
# GitHub Actions does not support arm* architectures on default
# runners. It is possible to accomplish this with a self-hosted runner
# if we want to add this in the future:
# https://docs.github.com/en/actions/hosting-your-own-runners/using-self-hosted-runners-in-a-workflow
arch: ["386", amd64]
exclude:
# Not a supported Go OS/architecture.
platform:
- os: ubuntu-latest
arch: "386"
- os: ubuntu-latest
arch: amd64
- os: macos-latest
arch: amd64
- os: windows-latest
arch: "386"
runs-on: ${{ matrix.os }}
- os: windows-latest
arch: amd64
# ARM64 compatibility tests are using actuated runners
# See https://github.com/open-telemetry/community/blob/main/docs/using-actuated.md
- os: actuated-arm64-2cpu-8gb
arch: arm64
runs-on: ${{ matrix.platform.os }}
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand All @@ -130,7 +135,7 @@ jobs:
cache-dependency-path: "**/go.sum"
- name: Run tests
env:
GOARCH: ${{ matrix.arch }}
GOARCH: ${{ matrix.platform.arch }}
run: make test-short

test-compatibility:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -50,6 +50,7 @@ The next release will require at least [Go 1.21].
This module includes OpenTelemetry Go's implementation of the Logs Bridge API.
This module is in an alpha state, it is subject to breaking changes.
See our [versioning policy](./VERSIONING.md) for more info. (#4961)
- ARM64 platform to the compatibility testing suite. (#4994)

### Fixed

Expand Down
2 changes: 2 additions & 0 deletions README.md
Expand Up @@ -53,6 +53,8 @@ Currently, this project supports the following environments.
| Ubuntu | 1.21 | amd64 |
| Ubuntu | 1.22 | 386 |
| Ubuntu | 1.21 | 386 |
| Linux | 1.22 | arm64 |
| Linux | 1.21 | arm64 |
| MacOS | 1.22 | amd64 |
| MacOS | 1.21 | amd64 |
| Windows | 1.22 | amd64 |
Expand Down

0 comments on commit ca5bb1f

Please sign in to comment.