Add ARM64 Support #3277
Merged
Add ARM64 Support #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RassK
force-pushed
the
arm64
branch
2 times, most recently
from
bab2afc
to
0c817c2
Compare
# Conflicts: # .github/workflows/build.yml # .github/workflows/ci.yml
| @@ -11,8 +11,8 @@ partial class Build : NukeBuild | |||
| [Parameter("Configuration to build. Default is 'Release'")] | |||
| readonly Configuration BuildConfiguration = Configuration.Release; | |||
|
|
|||
| [Parameter("Platform to build - x86 or x64. Default is 'x64'")] | |||
| readonly MSBuildTargetPlatform Platform = MSBuildTargetPlatform.x64; | |||
| [Parameter("Platform to build - x86, x64, ARM64. Default is current architecture.")] | |||
There was a problem hiding this comment.
nit: Provide a better clarity her - "Default is current architecture."
# Conflicts: # .github/workflows/build.yml
# Conflicts: # .github/workflows/build-nuget-packages.yml # .github/workflows/release.yml
8 tasks
Kielek
approved these changes
Mar 5, 2024
pjanotti
approved these changes
Mar 5, 2024
Kielek
reviewed
Mar 6, 2024
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
pellared
approved these changes
Mar 6, 2024
|
@rajkumar-rangaraj, @zacharycmontoya, do you see any objections to merge it? If no, I will adjust merge build requierments. |
Merged
See #3307 |
zacharycmontoya
approved these changes
Mar 6, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #1865
Fixes #2181
Towards #2314
Towards #2453
What
Adds ARM64 support for ubuntu, debian and alpine.
CentOS based images are not supported with .NET 6 and .NET 7
Tests
Tests .NET 6, .NET 7 and .NET 8.
Follow up
Confluent.Kafka 1.4.0is not supported by arm64, is disabled temporarily due missing platform filtration capabilities.Confluent.Kafka 1.6.2does not work on x64 and arm64. This seems to require separate focus.Follow up task here > #3306
Checklist
CHANGELOG.mdis updated.