fix: Rename deprecated vim.treesitter calls
#120
Conversation
|
Thank you, but that would break users on 0.8. You should be using nvim-treesitter's new compat module; see the recent PR there. |
|
Alright. Did you mean this when you said "compat module": |
|
Yes, exactly! |
|
OK, I will try to contribute some of the compatibility shims I need, then I'll try to get back to you. |
|
Can't you just use the ones from nvim-treesitter? Or is there one missing that you'd need? |
|
I would need |
|
Hi, can this be merged? I'm sorry if I'm wasting your time. |
|
This seems to make neovim 0.7-0.8 broken with the playground plugin installed. |
nvim-treesitter-playground broke neovim older than 0.9 (see nvim-treesitter/playground#120), so I pin the plugin at an older version that is compatible with neovim 0.7.x and 0.8.x.
|
Yes, the compat module was just used in some places. Could you create a PR that would use it everywhere in this diff? |
PR nvim-treesitter#120 used nvim-treesitter.compat in some occasions but not all: https://github.com/nvim-treesitter/playground/pull/120/files This made nvim-treesitter-playground incompatible with older Neovim versions nvim-treesitter#120 (comment) Although, we generally only support latest Neovim stable this is a unnecessary inconsistency in the code base. Also when, ts_compat should be removed in future it should there will be only one source of `get_node_text` that can then be swapped consistently around the whole code base. nvim-treesitter-playground is especially useful for older Neovim versions that don't have the built-in playground yet.
PR #120 used nvim-treesitter.compat in some occasions but not all: https://github.com/nvim-treesitter/playground/pull/120/files This made nvim-treesitter-playground incompatible with older Neovim versions #120 (comment) Although, we generally only support latest Neovim stable this is a unnecessary inconsistency in the code base. Also when, ts_compat should be removed in future it should there will be only one source of `get_node_text` that can then be swapped consistently around the whole code base. nvim-treesitter-playground is especially useful for older Neovim versions that don't have the built-in playground yet.
ref: neovim/neovim@cbbf8bd