This repository has been archived by the owner on Jan 17, 2024. It is now read-only.
fix: only have one source of get_node_text (nvim-treesitter.compat)
#124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR nvim-treesitter#120 used nvim-treesitter.compat in some occasions but not all: https://github.com/nvim-treesitter/playground/pull/120/files This made nvim-treesitter-playground incompatible with older Neovim versions nvim-treesitter#120 (comment) Although, we generally only support latest Neovim stable this is a unnecessary inconsistency in the code base. Also when, ts_compat should be removed in future it should there will be only one source of `get_node_text` that can then be swapped consistently around the whole code base. nvim-treesitter-playground is especially useful for older Neovim versions that don't have the built-in playground yet.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #120 used nvim-treesitter.compat in some occasions but not all: https://github.com/nvim-treesitter/playground/pull/120/files
This made nvim-treesitter-playground incompatible with older Neovim versions #120 (comment)
Although, we generally only support latest Neovim stable this is a unnecessary inconsistency in the code base. Also when, ts_compat should be removed in future it should there will be only one source of
get_node_textthat can then be swapped consistently around the whole code base. nvim-treesitter-playground is especially useful for older Neovim versions that don't have the built-in playground yet.@wookayin