Skip to content
This repository has been archived by the owner on Jan 17, 2024. It is now read-only.

fix: only have one source of get_node_text (nvim-treesitter.compat) #124

Merged
merged 1 commit into from Apr 15, 2023

Conversation

theHamsta
Copy link
Member

PR #120 used nvim-treesitter.compat in some occasions but not all: https://github.com/nvim-treesitter/playground/pull/120/files

This made nvim-treesitter-playground incompatible with older Neovim versions #120 (comment)

Although, we generally only support latest Neovim stable this is a unnecessary inconsistency in the code base. Also when, ts_compat should be removed in future it should there will be only one source of get_node_text that can then be swapped consistently around the whole code base. nvim-treesitter-playground is especially useful for older Neovim versions that don't have the built-in playground yet.

@wookayin

PR nvim-treesitter#120 used nvim-treesitter.compat in some occasions but not all:
https://github.com/nvim-treesitter/playground/pull/120/files

This made nvim-treesitter-playground incompatible with older
Neovim versions nvim-treesitter#120 (comment)

Although, we generally only support latest Neovim stable this is a
unnecessary inconsistency in the code base. Also when, ts_compat should
be removed in future it should there will be only one source of
`get_node_text` that can then be swapped consistently around the whole
code base. nvim-treesitter-playground is especially useful for older
Neovim versions that don't have the built-in playground yet.
@theHamsta theHamsta requested review from clason and amaanq April 15, 2023 14:33
@amaanq amaanq merged commit 2b81a01 into nvim-treesitter:master Apr 15, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants