Skip to content
This repository has been archived by the owner on Jan 17, 2024. It is now read-only.

Please provide tag for old versions or make it compatible with neovim 0.7-0.8 #123

Closed
wookayin opened this issue Apr 14, 2023 · 7 comments
Closed

Comments

@wookayin
Copy link
Member

wookayin commented Apr 14, 2023

Since commit db54848 (#120), playground requires neovim 0.9 or higher (it depends on treesitter 90ead4ed or higher). I think this is too high requirement version for neovim because there are some system that is still using neovim 0.7 or 0.8.

While I would suggest lower the minimum required neovim version of this plugin, it'd be a good idea to provide tags (like v0.7.0) for last compatible version like nvim-tresitter plugin.

@clason
Copy link
Contributor

clason commented Apr 14, 2023

PRs restoring compatibility with 0.8 are welcome (that PR was not supposed to break on 0.8). But we cannot support older versions; it is just too much effort.

And the goal is to deprecate this plugin sooner rather than later. If someone wants to fork it and provide support for older versions, they are very welcome to do so.

@clason clason closed this as completed Apr 14, 2023
@wookayin
Copy link
Member Author

Can we at least maintain tags?

@clason
Copy link
Contributor

clason commented Apr 14, 2023

Not planned, at least not retroactively, sorry. If somebody else has the time and interest in maintaining an LTS version of this plugin, they can do so. Our efforts are focused on improving the official core implementation

@wookayin
Copy link
Member Author

Makes sense, thanks! I always appreciate your efforts on neovim core development (and this plugin too).

@clason
Copy link
Contributor

clason commented Apr 14, 2023

(but I hope someone provides a fix to restore the 0.8 compatibility)

@dtomvan
Copy link
Contributor

dtomvan commented Apr 15, 2023

Wait, wasn't the entire point of the nvim-treesitter.compat module to add compatibility between both nvim 0.8 and 0.9? How does nvim-treesitter-latest depend on nvim 0.9? If it does then the point of the compat module would be defeated...

@clason
Copy link
Contributor

clason commented Apr 15, 2023

Again, this was a mistake in the PR that slipped past review; a followup PR to fix this is welcome.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants