Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python bindings #14

Merged
merged 15 commits into from May 14, 2024
Merged

Python bindings #14

merged 15 commits into from May 14, 2024

Conversation

boxanm
Copy link
Contributor

@boxanm boxanm commented May 10, 2024

I finally finished the mapper's Python bindings that I started back in 2022.

@boxanm boxanm added the enhancement New feature or request label May 10, 2024
@boxanm boxanm changed the base branch from master to develop May 10, 2024 18:58
simonpierredeschenes
simonpierredeschenes requested changes May 12, 2024
View reviewed changes
Copy link
Contributor

@simonpierredeschenes simonpierredeschenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, especially for the python example! There are a few minor comments to address, but it looks good overall

python/src/cell_manager.cpp Outdated Show resolved Hide resolved
python/src/cell_manager.h Outdated Show resolved Hide resolved
python/src/hard_drive_cell_manager.cpp Outdated Show resolved Hide resolved
python/src/hard_drive_cell_manager.h Outdated Show resolved Hide resolved
python/src/map.cpp Outdated Show resolved Hide resolved
python/src/ram_cell_manager.cpp Outdated Show resolved Hide resolved
python/src/ram_cell_manager.h Outdated Show resolved Hide resolved
python/src/trajectory.cpp Outdated Show resolved Hide resolved
python/src/trajectory.cpp Outdated Show resolved Hide resolved
python/src/trajectory.h Outdated Show resolved Hide resolved
@boxanm boxanm merged commit 98d6442 into develop May 14, 2024
@boxanm boxanm deleted the python_bindings branch May 14, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpierredeschenes simonpierredeschenes simonpierredeschenes approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boxanm @simonpierredeschenes