Add OpenMP support in CMake #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMakeLists.txt
Outdated
| #-------------------- | ||
| # DEPENDENCY: OpenMP (optional) | ||
| #-------------------- | ||
| set(USE_OPEN_MP TRUE CACHE BOOL "Set to FALSE to not use OpenMP") |
There was a problem hiding this comment.
I'd recommend to default to FALSE instead. Otherwise users will be running into mysterious performance changes of their systems (using more cores sometimes is actually slow and typically affects other processes running in parallel). See norlab-ulaval/libnabo#66 for a corresponding PR for libnabo.
There was a problem hiding this comment.
Sure, I'll change that! (I took the code from the CMakeLists.txt of libnabo, this is why the default option was set to TRUE.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.