Allow nf-core download -r to download commits
#2906
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nf-core-bot fix linting |
fellen31
force-pushed
the
download_commits
branch
from
74bacb8
to
937e442
Compare
|
@nf-core-bot fix linting |
ewels
reviewed
Apr 4, 2024
Comment on lines
+1013
to
+1016
| # Get commit information from github api | ||
| commit_response = gh_api.safe_get(f"https://api.github.com/repos/{pipeline}/commits?sha={branch['name']}") | ||
| for commit in commit_response.json(): | ||
| wf_commits.append(commit["sha"]) |
There was a problem hiding this comment.
I am a bit scared of this - is it really getting every single commit from a repo? In some repos that could be a huge response.
I wonder if we move this into a separate function call and only do it if we need to - that is, once we're sure that the user is passing a commit and is not going to use a branch or a tag?
I suspect that the number of people wanting exact commits to be a tiny proportion, so I don't want to slow down / risk crashes for the majority.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mimic the behaviour of
nextflow run -rand allow selected commit(s) to be downloaded.https://nfcore.slack.com/archives/CE5LG7WMB/p1712143905189639
Not sure about the effect it will have on Tower downloads.
PR checklist
CHANGELOG.mdis updateddocsis updated