Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test data uses paths instead of config map #2877

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

adamrtalbot
Copy link
Contributor

@adamrtalbot adamrtalbot commented Mar 19, 2024

Module test data uses paths rather than config map

Motivation:

  • This makes modules and subworkflows completely portable, just depending on the parameter for the base path. You can install them in your pipeline code and have tests for everything!

We've been using it quite effectively for fetchngs and rnaseq. We were able to add test for all modules rnaseq with one module update!

Requires some more automation to make it simpler.

Will close #2858

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@adamrtalbot adamrtalbot linked an issue Mar 19, 2024 that may be closed by this pull request
@adamrtalbot adamrtalbot changed the title 2858 Test data uses paths instead of config map Test data uses paths instead of config map Mar 19, 2024
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to paths looks good to me for the modules repo 🙂 but we should also add the nf-test config file to the pipeline template, otherwise tests are not functional on pipelines.
I think it would be better to transition to nf-test completely, we have been adding nf-test changes slowly to the pipeline template and I think it's becoming confusing, and some of the functionality is currently broken. Do you think it would be good to make a big nf-test PR?

@adamrtalbot
Copy link
Contributor Author

Yep I think so. Let's get it all done in one big release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use paths rather than config map for test data
3 participants