Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added patch command for subworkflows #2861

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from
Open

added patch command for subworkflows #2861

wants to merge 16 commits into from

Conversation

ctuni
Copy link
Contributor

@ctuni ctuni commented Mar 18, 2024

Related to issue: #1891

Is there a straightforward way to test this?

Copy link
Contributor

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @ctuni,

It looks like this pull-request is has been made against the ctuni/tools master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the ctuni/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@ctuni ctuni changed the base branch from master to dev March 18, 2024 11:21
@ctuni ctuni linked an issue Mar 18, 2024 that may be closed by this pull request
@ctuni ctuni requested a review from mashehu March 18, 2024 11:31
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 74.85%. Comparing base (03646eb) to head (31505ab).

❗ Current head 31505ab differs from pull request most recent head cdd9cfb. Consider uploading reports for the commit cdd9cfb to get more accurate results

Files Patch % Lines
nf_core/__main__.py 40.00% 9 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctuni ctuni removed the request for review from mashehu March 18, 2024 12:03
@mashehu
Copy link
Contributor

mashehu commented Mar 18, 2024

for testing you can do similar things to https://github.com/nf-core/tools/blob/master/tests/modules/patch.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement nf-core subworkflows patch command
2 participants