#657 Validate input files from config file #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t of supported subsampling flags
…ile names for spaces and makes sure they're in the right directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
What is the goal of this pull request? What does this pull request change?
This request attempts to fix issue 657 and validate the input files from the config file by making sure the file names do not have spaces in them and exist in the given directory. It raises an error and prints what went wrong if the file name is not valid.
Related issue(s)
Fixes #
Related to #657
Testing
What steps should be taken to test the changes you've proposed?
Test to see if the program exits correctly and prints a descriptive error message when an input file with an invalid name is used.
If you added or changed behavior in the codebase, did you update the tests, or do you need help with this?
Yes, my partner and I changed the codebase but did not updated the tests. We would need help with this.
Release checklist
If this pull request introduces backward incompatible changes, complete the following steps for a new release of the workflow:
docs/src/reference/change_log.mdin this pull request to document these changes and the new version number.If this pull request introduces new features, complete the following steps:
docs/src/reference/change_log.mdin this pull request to document these changes by the date they were added.