Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specification of container image in workflow rebuild-100k.yml #1067

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow specification of container image in workflow rebuild-100k.yml #1067

wants to merge 1 commit into from

Conversation

corneliusroemer
Copy link
Member

@corneliusroemer corneliusroemer commented May 5, 2023 •
edited

Useful to test image compatibility

jameshadfield
jameshadfield reviewed May 8, 2023
View reviewed changes
Copy link
Member

@jameshadfield jameshadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fine to me. Note that this workflow only runs the filtering + merging steps, so it's perhaps not the best way to test an image's behavior with an actual phylogenetics pipeline.

@corneliusroemer
Copy link
Member Author

Thanks @jameshadfield - it's not meant to be the only test for an image. Just helping increase "coverage" by being able to test more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameshadfield jameshadfield jameshadfield left review comments

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Nextstrain planning (archived)
Status: New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@corneliusroemer @jameshadfield