feat: implement clack DO NOT MERGE #6293
Draft
+40,050
−33,403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khendrikse
changed the title
khendrikse
changed the title
5 tasks
* chore: convert api command to use clack * chore: add beginning of styleguide
This was referenced Jan 10, 2024
* chore: improve API command with spinner and better formatting * chore: add support for json only
* chore: convert api command to use clack * chore: convert unlink to use NetlifyLog
5 tasks
* chore: improve API command with spinner and better formatting * chore: convert api command to use clack * chore: convert link to use NetlifyLog and clack * chore: updates for converting the api command (#6295) * chore: improve API command with spinner and better formatting * chore: add support for json only * chore: more converting of link and changed json only support * revert weird chalk helper * chore: implement some feedback
This was referenced Jan 15, 2024
* chore: converts status command to clack * chore: fix json output * chore: manage logged out state --------- Co-authored-by: Lewis Thorley <lewis.thorley@netlify.com>
This was referenced Jan 17, 2024
Co-authored-by: Lewis Thorley <lewis.thorley@netlify.com>
* chore: convert logs:functions * chore: convert logs:build * chore: convert open command (#6325) * chore: fix log tests and mocks --------- Co-authored-by: Lewis Thorley <lewis.thorley@netlify.com>
* chore: following all paths from watch command and converting to clack * chore: ensuring subcommands collect messages and do not repeat intros * chore: add style guide for child commands * chore: add style guide for child commands * chore: add style guide for child commands with js * chore: remove negated condition * chore: finish child command explanations * chore: fix init tests by using return key instead of new line to confirm' * chore: remove console logs * chore: ensure create routes from init are covered and join up * chore: fix create from template tests * chore: remove reference to arrow keys for consistency with other select commands * Update STYLEGUIDE.md Co-authored-by: Erica Pisani <pisani.erica@gmail.com> * Update STYLEGUIDE.md Co-authored-by: Erica Pisani <pisani.erica@gmail.com> * Update STYLEGUIDE.md Co-authored-by: Erica Pisani <pisani.erica@gmail.com> * Update src/commands/init/init.ts Co-authored-by: Erica Pisani <pisani.erica@gmail.com> --------- Co-authored-by: Lewis Thorley <lewis.thorley@netlify.com> Co-authored-by: Erica Pisani <pisani.erica@gmail.com>
* chore: convert sites:list and sites:delete to clack * chore: fix ternary style * Update src/commands/sites/sites-delete.ts Co-authored-by: Erica Pisani <pisani.erica@gmail.com> * Update src/commands/sites/sites-delete.ts Co-authored-by: Erica Pisani <pisani.erica@gmail.com> * chore: remove _ from error --------- Co-authored-by: Lewis Thorley <lewis.thorley@netlify.com> Co-authored-by: Erica Pisani <pisani.erica@gmail.com>
Co-authored-by: Lewis Thorley <lewis.thorley@netlify.com>
* chore: in progress of converting command having updated types * chore: convert create template command to clack complete * chore: convert create template command to clack complete --------- Co-authored-by: Lewis Thorley <lewis.thorley@netlify.com>
* chore: wip convert dev command and stream logs into NetlifyLog - need to not call outro if framework * chore: format live tunnel changes * chore: capture all logs from @netlify/build * chore: format styles * chore: fix log breaking tests * chore: log function detection with logger and remove outro * chore: convert function registration output to clack * chore: remove old comments from shell file * chore: add expect-errors back * chore: add expect-errors back * chore: remove comment * chore: handle formatters in console overrides * chore: remove log * chore: ensure tests pass where we assert what is printed for child command * chore: ensure tests pass where we assert what is printed for child command * chore: remove pnpm added by mistake * In progress of fixing framework detection tests * chore: fix snapshot tests from frameworks * chore: fix lint issues * chore: fix lint issues * chore: fix lint issues * chore: fix prettier errors * chore: fix error not defined in addons logic * chore: fix import order * chore: fix empty line * chore: fix unpublished * chore: fix express error --------- Co-authored-by: Lewis Thorley <lewis.thorley@netlify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
This is a big branch, containing all the work for https://linear.app/netlify/issue/CT-101/cli-design-system.
BEFORE MERGING, REMOVE THE GITHUB ACTIONS LOGIC THAT RUNS TESTS ON PR'S TO THIS BRANCH.
We're working on aligning the styles in the CLI. This PR contains all the work that has been done for that. But due to the enormity of the review work that would otherwise be necessary, smaller PR's will be merged into this bigger PR after being reviewed by the team, keeping the workload manageable.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)