Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert logout command #6321

Conversation

khendrikse
Copy link
Contributor

πŸŽ‰ Thanks for submitting a pull request! πŸŽ‰

Summary

Fixes: https://linear.app/netlify/issue/CT-501/convert-logout-command-to-clack

This converts the logout command into using the new NetlifyLog. It is part of a bigger piece of work that can be seen in #6293. This is also the reason why this PR is merged into the branch CP-101/design-system-clack-implementation. It's a way in which I'm trying to keep possible failing tests, but also the review work to a minimum amount of work for those who are reviewing.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

@khendrikse khendrikse requested a review from a team as a code owner January 15, 2024 10:19
Base automatically changed from CP-478/convert-login-command-to-clack to CP-101/design-system-clack-implementation January 15, 2024 10:45
@khendrikse khendrikse force-pushed the CP-501/convert-logout-command-to-clack branch from 437b4bd to 4f0b563 Compare January 15, 2024 11:13
@khendrikse khendrikse merged commit 7b2bba2 into CP-101/design-system-clack-implementation Jan 15, 2024
30 checks passed
@khendrikse khendrikse deleted the CP-501/convert-logout-command-to-clack branch January 15, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants