-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updates for converting the api command #6295
chore: updates for converting the api command #6295
Conversation
0c074d0
to
8596b3f
Compare
Something that I'd like some advice about is this: I've now implemented this change: Before: After: Because I really dislike when that outro part only has a little hook... But sometimes we might not have a message to show there... |
@khendrikse I understand. When there isn't a message will it end with the last line of the table above it? I think that is fine. |
Yeah that's the problem @samkap, right now we don't have easy logic that will allow that. We could default to 'Done' or 'Finished' if someone does not pass a message? |
8596b3f
to
96688c6
Compare
493a6a1
into
CP-101/design-system-clack-implementation
* chore: improve API command with spinner and better formatting * chore: add support for json only
* chore: improve API command with spinner and better formatting * chore: add support for json only
* chore: improve API command with spinner and better formatting * chore: convert api command to use clack * chore: convert link to use NetlifyLog and clack * chore: updates for converting the api command (#6295) * chore: improve API command with spinner and better formatting * chore: add support for json only * chore: more converting of link and changed json only support * revert weird chalk helper * chore: implement some feedback
π Thanks for submitting a pull request! π
Summary
This adds some changes to converting the api command into using the new NetlifyLog. It is part of a bigger piece of work that can be seen in #6293. This is also the reason why this PR is merged into the branch CP-101/design-system-clack-implementation. It's a way in which I'm trying to keep possible failing tests, but also the review work to a minimum amount of work for those who are reviewing.
Before
After
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)