New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add patches to make C and Cpp packages installable #72
base: master
Are you sure you want to change the base?
Conversation
Generated package as a proof of concept: |
I appreciate your individual commits with helpful messages, instead of one big unauditable mess. Thanks for informing me that my library is being used in a popular open-source software package, LibreOffice. I do have some fears that some of the changes you propose might only be appropriate for a particular platform (e.g. Linux vs. BSD) or for a particular distribution (e.g. SUSE-specific conventions or constructs). I will allocate some time in the coming days to understand the proposed changes and what effects they have. I will certainly solicit you with questions during my audit if there's something I don't understand. |
This PR seems have conflicts now. @scarabeusiv , do you have a plan to rebase this? Thanks. |
@lwhsu rebased. |
@nayuki Can you merge this? |
Any progress? |
I can't talk about any of the BSDs (but I suspect it's the same for them, too) but I'm pretty sure every distribution wants install targets with a way to pass PREFIX and DESTDIR. So I added the patches from this PR to my distro's packaging. |
Makefiles from this PR are more Linux- and BSD-friendly than the current one, I guess. |
1,5 weeks and this PR can celebrate that it is open for 8 months 🧐 |
@nayuki friendly ping |
This PR need to be rebased to version 1.6.0 btw. |
@nayuki another ping, this PR should probably get merged. These new makefiles look fine. |
Implemented CMake build and installation support: https://github.com/EasyCoding/qrcodegen-cmake
@nayuki I can send a PR with CMake support if you want. |
As the package is now used by libreoffice we at SUSE needed to be able to safely install the package on the distribution while avoiding conflicts.
Fixes issues #61 and #63