Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add patches to make C and Cpp packages installable #72

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

scarabeusiv
Copy link

As the package is now used by libreoffice we at SUSE needed to be able to safely install the package on the distribution while avoiding conflicts.

Fixes issues #61 and #63

@scarabeusiv
Copy link
Author

Generated package as a proof of concept:
https://build.opensuse.org/package/show/LibreOffice:Factory/QR-Code-generator

@nayuki
Copy link
Owner

nayuki commented Dec 3, 2019

I appreciate your individual commits with helpful messages, instead of one big unauditable mess.

Thanks for informing me that my library is being used in a popular open-source software package, LibreOffice.

I do have some fears that some of the changes you propose might only be appropriate for a particular platform (e.g. Linux vs. BSD) or for a particular distribution (e.g. SUSE-specific conventions or constructs).

I will allocate some time in the coming days to understand the proposed changes and what effects they have. I will certainly solicit you with questions during my audit if there's something I don't understand.

c/Makefile Outdated Show resolved Hide resolved
cpp/Makefile Show resolved Hide resolved
c/Makefile Outdated Show resolved Hide resolved
c/Makefile Outdated Show resolved Hide resolved
c/Makefile Outdated Show resolved Hide resolved
cpp/Makefile Outdated Show resolved Hide resolved
cpp/Makefile Outdated Show resolved Hide resolved
cpp/Makefile Outdated Show resolved Hide resolved
@lwhsu
Copy link

lwhsu commented Jan 20, 2020

This PR seems have conflicts now. @scarabeusiv , do you have a plan to rebase this? Thanks.

@scarabeusiv
Copy link
Author

@lwhsu rebased.

@xvitaly
Copy link

xvitaly commented Feb 3, 2020

@nayuki Can you merge this?

@ilya-fedin
Copy link

Any progress?

@heirecka
Copy link

heirecka commented Apr 9, 2020

I do have some fears that some of the changes you propose might only be appropriate for a particular platform (e.g. Linux vs. BSD) or for a particular distribution (e.g. SUSE-specific conventions or constructs).

I can't talk about any of the BSDs (but I suspect it's the same for them, too) but I'm pretty sure every distribution wants install targets with a way to pass PREFIX and DESTDIR. So I added the patches from this PR to my distro's packaging.

@ilya-fedin
Copy link

ilya-fedin commented Apr 9, 2020

Makefiles from this PR are more Linux- and BSD-friendly than the current one, I guess.

@ilya-fedin
Copy link

ilya-fedin commented Jul 22, 2020

1,5 weeks and this PR can celebrate that it is open for 8 months 🧐

@ilya-fedin
Copy link

ilya-fedin commented Aug 7, 2020

@nayuki friendly ping

@xvitaly
Copy link

xvitaly commented Aug 7, 2020

This PR need to be rebased to version 1.6.0 btw.

@powpingdone
Copy link

@nayuki another ping, this PR should probably get merged. These new makefiles look fine.

@xvitaly
Copy link

xvitaly commented Aug 9, 2021

Implemented CMake build and installation support: https://github.com/EasyCoding/qrcodegen-cmake

git clone https://github.com/nayuki/QR-Code-generator.git qrcodegen
git clone https://github.com/EasyCoding/qrcodegen-cmake.git qrcodegen-cmake
cp -f qrcodegen-cmake/CMakeLists.txt qrcodegen/
mkdir -p qrcodegen/build
cd qrcodegen/build
cmake ..
cmake --build .

@nayuki I can send a PR with CMake support if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants