Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] qr-code-generator creating 2 libraries with same file name #2691

Open
madebr opened this issue Aug 27, 2020 · 3 comments
Open

[question] qr-code-generator creating 2 libraries with same file name #2691

madebr opened this issue Aug 27, 2020 · 3 comments
Labels
question Further information is requested

Comments

@madebr
Copy link
Contributor

madebr commented Aug 27, 2020

Hello!

I have a package requiring qr-code-generator.
As you can see, it has both a c and c++ version.
The recipe on cci currently only packages the c++ version.

But I need the c version.

How would you fix this?
The problem is that qr-code-generator builds all its libraries with the same name: qrcodegen (with no postfix).

  1. Add a enable_c option and build either the c or c++ version
  2. build the c++ library as qrcodegen++/qrcodegenpp`` and build both (c library as qrcodegen)
  3. add a qr-code-generator-c recipe

Solution 1 does allow to have both the c and c++ in the build tree, because options are global.

Solution 2 requires patches to all dependencies.

Solution 3 is the easiest because it does not need any patches to any recipes needing the c version. Also it allows to combine the c and c++ versions without patching. The only downside is having to maintain an extra recipe.

What solution do you guys prefer? An alternative of which I didn't think of?

@madebr madebr added the question Further information is requested label Aug 27, 2020
@madebr madebr changed the title [question] qr-code-generator creating 2 libraries with same library [question] qr-code-generator creating 2 libraries with same file name Aug 27, 2020
@Croydon
Copy link
Contributor

Croydon commented Aug 28, 2020

References:

nayuki/QR-Code-generator#63
nayuki/QR-Code-generator#72

@xvitaly
Copy link

xvitaly commented Aug 9, 2021

Implemented CMake build and installation support: https://github.com/EasyCoding/qrcodegen-cmake

git clone https://github.com/nayuki/QR-Code-generator.git qrcodegen
git clone https://github.com/EasyCoding/qrcodegen-cmake.git qrcodegen-cmake
cp -f qrcodegen-cmake/CMakeLists.txt qrcodegen/
mkdir -p qrcodegen/build
cd qrcodegen/build
cmake ..
cmake --build .

@Croydon
Copy link
Contributor

Croydon commented Aug 9, 2021

Seems to be fixed in 1.7.0

nayuki/QR-Code-generator#63

nayuki/QR-Code-generator@5300e40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants