Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump qr-code-generator/1.7.0 #6786

Merged
merged 5 commits into from
Aug 11, 2021
Merged

Conversation

Nekto89
Copy link
Contributor

@Nekto89 Nekto89 commented Aug 9, 2021

  • remove languages from description
  • modernize recipe
  • update test_package because of changed header name
  • integrate patch into CMakeLists.txt

Specify library name and version: qr-code-generator/1.7.0

I've noticed that there is a new version available so I've decided to bump it in CCI.
Version check is based on existing files. It's not pretty but works.


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

- remove languages from description
- modernize recipe
- update test_package because of changed header name
- integrate patch into CMakeLists.txt
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@leha-bot
Copy link
Contributor

leha-bot commented Aug 9, 2021

@Nekto89 hello, I also kindly ask you to see our repo with CMake config (proposed for upstream here ) and integrate some parts from it :)

@madebr hello, what do you think about this idea?
Thanks you all for attention and your work 😊

P.S. Also this PR could close #2691 with patches from our CMake :)

@conan-center-bot
Copy link
Collaborator

All green in build 3 (9b4fddd318df12d3620f5d47afa95f33f7f1ee6b):

  • qr-code-generator/1.4.0@:
    All packages built successfully! (All logs)

  • qr-code-generator/1.5.0@:
    All packages built successfully! (All logs)

  • qr-code-generator/1.6.0@:
    All packages built successfully! (All logs)

  • qr-code-generator/1.7.0@:
    All packages built successfully! (All logs)

@Nekto89
Copy link
Contributor Author

Nekto89 commented Aug 10, 2021

@Nekto89 hello, I also kindly ask you to see our repo with CMake config (proposed for upstream here ) and integrate some parts from it :)

I wasn't planning on making larger changes. This requires adding new options, introducing components, adding test for C interface, etc. IMO it should be done in separate PR.

@SSE4 SSE4 requested a review from uilianries August 10, 2021 14:04
@SSE4
Copy link
Contributor

SSE4 commented Aug 10, 2021

I wasn't planning on making larger changes. This requires adding new options, introducing components, adding test for C interface, etc. IMO it should be done in separate PR.

agree, no need to do everything at one shot

@conan-center-bot conan-center-bot merged commit 453a5d3 into conan-io:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants