Fix monitoring e2e failures due to missing CRBs #11506

machadovilaca · 2024-03-13T22:10:50Z

What this PR does

Before this PR:

e2e monitoring tests flakiness due to outdated configs
because some times pods don't have necessary permissions to access resources

After this PR:

no longer failing

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Design: A design document was considered and is present (link) or not required
PR: The PR description is expressive enough and will help future contributors
Code: Write code that humans can understand and Keep it simple
Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
Upgrade: Impact of this change on upgrade flows was considered and addressed if required
Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
Community: Announcement to kubevirt-dev was considered

Release note

none

machadovilaca · 2024-03-14T10:59:53Z

/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring

kubevirt-bot · 2024-03-14T10:59:56Z

@machadovilaca: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-kubevirt-apidocs-1.1
/test pull-kubevirt-build-1.1
/test pull-kubevirt-build-arm64-1.1
/test pull-kubevirt-check-unassigned-tests-1.1
/test pull-kubevirt-client-python-1.1
/test pull-kubevirt-e2e-k8s-1.26-sig-compute-1.1
/test pull-kubevirt-e2e-k8s-1.26-sig-monitoring-1.1
/test pull-kubevirt-e2e-k8s-1.26-sig-network-1.1
/test pull-kubevirt-e2e-k8s-1.26-sig-operator-1.1
/test pull-kubevirt-e2e-k8s-1.26-sig-storage-1.1
/test pull-kubevirt-e2e-k8s-1.27-ipv6-sig-network-1.1
/test pull-kubevirt-e2e-k8s-1.27-sig-compute-1.1
/test pull-kubevirt-e2e-k8s-1.27-sig-compute-realtime-1.1
/test pull-kubevirt-e2e-k8s-1.27-sig-network-1.1
/test pull-kubevirt-e2e-k8s-1.27-sig-operator-1.1
/test pull-kubevirt-e2e-k8s-1.27-sig-performance-1.1
/test pull-kubevirt-e2e-k8s-1.27-sig-storage-1.1
/test pull-kubevirt-e2e-k8s-1.28-sig-compute-1.1
/test pull-kubevirt-e2e-k8s-1.28-sig-compute-migrations-1.1
/test pull-kubevirt-e2e-k8s-1.28-sig-network-1.1
/test pull-kubevirt-e2e-k8s-1.28-sig-operator-1.1
/test pull-kubevirt-e2e-k8s-1.28-sig-storage-1.1
/test pull-kubevirt-e2e-kind-1.27-sriov-1.1
/test pull-kubevirt-e2e-kind-1.27-vgpu-1.1
/test pull-kubevirt-e2e-windows2016-1.1
/test pull-kubevirt-generate-1.1
/test pull-kubevirt-manifests-1.1
/test pull-kubevirt-prom-rules-verify-1.1
/test pull-kubevirt-unit-test-1.1
/test pull-kubevirt-verify-go-mod-1.1

The following commands are available to trigger optional jobs:

/test build-kubevirt-builder-1.1
/test pull-kubevirt-check-tests-for-flakes-1.1
/test pull-kubevirt-code-lint-1.1
/test pull-kubevirt-e2e-arm64-1.1
/test pull-kubevirt-e2e-k8s-1.25-fips-sig-compute-1.1
/test pull-kubevirt-e2e-k8s-1.26-ipv6-sig-network-1.1
/test pull-kubevirt-e2e-k8s-1.26-sig-compute-root-1.1
/test pull-kubevirt-e2e-k8s-1.26-sig-network-multus-v4-1.1
/test pull-kubevirt-e2e-k8s-1.26-sig-storage-root-1.1
/test pull-kubevirt-e2e-k8s-1.26-single-node-1.1
/test pull-kubevirt-e2e-k8s-1.26-swap-enabled-1.1
/test pull-kubevirt-gosec-1.1
/test pull-kubevirt-goveralls-1.1
/test pull-kubevirt-metrics-lint-1.1
/test pull-kubevirt-unit-test-arm64-1.1
/test pull-kubevirt-verify-rpms-1.1

Use /test all to run the following jobs that were automatically triggered:

pull-kubevirt-apidocs-1.1
pull-kubevirt-build-1.1
pull-kubevirt-build-arm64-1.1
pull-kubevirt-check-tests-for-flakes-1.1
pull-kubevirt-check-unassigned-tests-1.1
pull-kubevirt-client-python-1.1
pull-kubevirt-code-lint-1.1
pull-kubevirt-e2e-arm64-1.1
pull-kubevirt-e2e-k8s-1.26-sig-compute-1.1
pull-kubevirt-e2e-k8s-1.26-sig-monitoring-1.1
pull-kubevirt-e2e-k8s-1.26-sig-network-1.1
pull-kubevirt-e2e-k8s-1.26-sig-operator-1.1
pull-kubevirt-e2e-k8s-1.26-sig-storage-1.1
pull-kubevirt-e2e-k8s-1.27-ipv6-sig-network-1.1
pull-kubevirt-e2e-k8s-1.27-sig-compute-1.1
pull-kubevirt-e2e-k8s-1.27-sig-network-1.1
pull-kubevirt-e2e-k8s-1.27-sig-operator-1.1
pull-kubevirt-e2e-k8s-1.27-sig-storage-1.1
pull-kubevirt-e2e-k8s-1.28-sig-compute-1.1
pull-kubevirt-e2e-k8s-1.28-sig-compute-migrations-1.1
pull-kubevirt-e2e-k8s-1.28-sig-network-1.1
pull-kubevirt-e2e-k8s-1.28-sig-operator-1.1
pull-kubevirt-e2e-k8s-1.28-sig-storage-1.1
pull-kubevirt-e2e-kind-1.27-sriov-1.1
pull-kubevirt-e2e-kind-1.27-vgpu-1.1
pull-kubevirt-e2e-windows2016-1.1
pull-kubevirt-generate-1.1
pull-kubevirt-goveralls-1.1
pull-kubevirt-manifests-1.1
pull-kubevirt-prom-rules-verify-1.1
pull-kubevirt-unit-test-1.1
pull-kubevirt-unit-test-arm64-1.1
pull-kubevirt-verify-go-mod-1.1

In response to this:

/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

machadovilaca · 2024-03-14T11:00:12Z

/test pull-kubevirt-e2e-k8s-1.26-sig-monitoring-1.1

Signed-off-by: João Vilaça <jvilaca@redhat.com>

kubevirt-bot · 2024-03-21T11:43:51Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xpivarc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

avlitman · 2024-03-21T11:48:05Z

/lgtm

kubevirt-bot · 2024-03-21T13:11:54Z

@machadovilaca: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubevirt-e2e-kind-1.27-vgpu	`e934406`	link	true	`/test pull-kubevirt-e2e-kind-1.27-vgpu-1.1`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

machadovilaca · 2024-03-26T10:32:02Z

/hold

machadovilaca · 2024-03-26T11:14:57Z

/unhold

enp0s3 · 2024-03-26T11:19:16Z

tests/testsuite/kubevirtresource.go

+	Eventually(func() error {
+		_, err = virtClient.KubeVirt(kv.Namespace).Patch(kv.GetName(), types.MergePatchType, patch, &metav1.PatchOptions{})
+		return err
+	}, 30*time.Second, 1*time.Second).Should(BeNil())


@assafad Can you elaborate on the reason we need it? I see that the test changes cluster roles only. How come this has something to do with the flake?

I'm not 100% sure, @machadovilaca would know better.

@enp0s3 since we removed the CRB from the pods, sometimes when this is executed the pods are not yet working properly and this call is not successful

avlitman · 2024-04-10T11:59:56Z

/retest

kubevirt-bot · 2024-04-16T16:24:32Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kubevirt-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 13, 2024

kubevirt-bot requested a review from kbidarkar March 13, 2024 22:10

kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Mar 13, 2024

kubevirt-bot requested a review from lyarwood March 13, 2024 22:10

kubevirt-bot added the size/M label Mar 13, 2024

machadovilaca mentioned this pull request Mar 14, 2024

[release-1.1] Deprecate cpu and memory exceeds alerts #11445

Merged

machadovilaca changed the title ~~Fix test failure due to missing CRBs~~ [release-1.1] Fix test failure due to missing CRBs Mar 18, 2024

Fix test failure due to missing CRBs

92fc55a

Signed-off-by: João Vilaça <jvilaca@redhat.com>

machadovilaca changed the base branch from release-1.1 to main March 21, 2024 11:43

machadovilaca changed the title ~~[release-1.1] Fix test failure due to missing CRBs~~ Fix test failure due to missing CRBs Mar 21, 2024

machadovilaca force-pushed the fix-test-failure-due-to-missing-crbs branch from e934406 to 92fc55a Compare March 21, 2024 11:43

machadovilaca changed the title ~~Fix test failure due to missing CRBs~~ Fix monitoring e2e failures due to missing CRBs Mar 21, 2024

kubevirt-bot assigned avlitman Mar 21, 2024

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024

assafad mentioned this pull request Mar 24, 2024

Fix monitoring test failure due to missing CRBs #11541

Closed

8 tasks

kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024

kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024

enp0s3 reviewed Mar 26, 2024

View reviewed changes

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 16, 2024

machadovilaca closed this Apr 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix monitoring e2e failures due to missing CRBs #11506

Fix monitoring e2e failures due to missing CRBs #11506

machadovilaca commented Mar 13, 2024 •

edited

machadovilaca commented Mar 14, 2024

kubevirt-bot commented Mar 14, 2024

machadovilaca commented Mar 14, 2024

kubevirt-bot commented Mar 21, 2024

avlitman commented Mar 21, 2024

kubevirt-bot commented Mar 21, 2024 •

edited

machadovilaca commented Mar 26, 2024

machadovilaca commented Mar 26, 2024

enp0s3 Mar 26, 2024

assafad Mar 26, 2024

machadovilaca Apr 4, 2024

avlitman commented Apr 10, 2024

kubevirt-bot commented Apr 16, 2024

Fix monitoring e2e failures due to missing CRBs #11506

Fix monitoring e2e failures due to missing CRBs #11506

Conversation

machadovilaca commented Mar 13, 2024 • edited

What this PR does

Why we need it and why it was done in this way

Special notes for your reviewer

Checklist

Release note

machadovilaca commented Mar 14, 2024

kubevirt-bot commented Mar 14, 2024

machadovilaca commented Mar 14, 2024

kubevirt-bot commented Mar 21, 2024

avlitman commented Mar 21, 2024

kubevirt-bot commented Mar 21, 2024 • edited

machadovilaca commented Mar 26, 2024

machadovilaca commented Mar 26, 2024

enp0s3 Mar 26, 2024

Choose a reason for hiding this comment

assafad Mar 26, 2024

Choose a reason for hiding this comment

machadovilaca Apr 4, 2024

Choose a reason for hiding this comment

avlitman commented Apr 10, 2024

kubevirt-bot commented Apr 16, 2024

machadovilaca commented Mar 13, 2024 •

edited

kubevirt-bot commented Mar 21, 2024 •

edited