Fix monitoring test failure due to missing CRBs #11541

assafad · 2024-03-19T08:35:29Z

What this PR does

Before this PR:
e2e monitoring tests are flaky due to outdated configs, because some times pods don't have necessary permissions to access resources.

After this PR:
no longer flaky.

Fixes https://issues.redhat.com/browse/CNV-38827

Special notes for your reviewer

Same fix as done by #11506 for release-1.1.

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Design: A design document was considered and is present (link) or not required
PR: The PR description is expressive enough and will help future contributors
Code: Write code that humans can understand and Keep it simple
Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
Upgrade: Impact of this change on upgrade flows was considered and addressed if required
Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
Community: Announcement to kubevirt-dev was considered

Release note

None

kubevirt-bot · 2024-03-19T08:35:32Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

kubevirt-bot · 2024-03-19T08:35:33Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign acardace for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

assafad · 2024-03-19T08:37:29Z

/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring

assafad · 2024-03-19T12:35:50Z

/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring

assafad · 2024-03-19T14:56:48Z

/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring

assafad · 2024-03-19T16:30:29Z

/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring

assafad · 2024-03-20T07:28:38Z

/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring

assafad · 2024-03-20T09:11:04Z

/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring

assafad · 2024-03-20T09:11:29Z

/test pull-kubevirt-e2e-k8s-1.28-sig-monitoring

kubevirt-bot · 2024-03-20T09:11:33Z

@assafad: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-kubevirt-apidocs
/test pull-kubevirt-build
/test pull-kubevirt-build-arm64
/test pull-kubevirt-check-unassigned-tests
/test pull-kubevirt-client-python
/test pull-kubevirt-code-lint
/test pull-kubevirt-e2e-k8s-1.27-sig-compute
/test pull-kubevirt-e2e-k8s-1.27-sig-network
/test pull-kubevirt-e2e-k8s-1.27-sig-operator
/test pull-kubevirt-e2e-k8s-1.27-sig-performance
/test pull-kubevirt-e2e-k8s-1.27-sig-storage
/test pull-kubevirt-e2e-k8s-1.28-sig-compute
/test pull-kubevirt-e2e-k8s-1.28-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-operator
/test pull-kubevirt-e2e-k8s-1.28-sig-storage
/test pull-kubevirt-e2e-k8s-1.29-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-compute
/test pull-kubevirt-e2e-k8s-1.29-sig-compute-migrations
/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring
/test pull-kubevirt-e2e-k8s-1.29-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-operator
/test pull-kubevirt-e2e-k8s-1.29-sig-storage
/test pull-kubevirt-e2e-kind-1.27-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-fossa
/test pull-kubevirt-generate
/test pull-kubevirt-manifests
/test pull-kubevirt-prom-rules-verify
/test pull-kubevirt-unit-test
/test pull-kubevirt-verify-go-mod

The following commands are available to trigger optional jobs:

/test build-kubevirt-builder
/test pull-kubevirt-build-s390x
/test pull-kubevirt-check-tests-for-flakes
/test pull-kubevirt-conformance-arm64
/test pull-kubevirt-e2e-arm64
/test pull-kubevirt-e2e-k8s-1.29-sig-compute-realtime
/test pull-kubevirt-e2e-k8s-1.29-sig-compute-root
/test pull-kubevirt-e2e-k8s-1.29-sig-network-multus-v4
/test pull-kubevirt-e2e-k8s-1.29-sig-storage-root
/test pull-kubevirt-e2e-k8s-1.29-single-node
/test pull-kubevirt-e2e-k8s-1.29-swap-enabled
/test pull-kubevirt-e2e-k8s-1.30-sig-compute
/test pull-kubevirt-e2e-k8s-1.30-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-operator
/test pull-kubevirt-e2e-k8s-1.30-sig-storage
/test pull-kubevirt-gosec
/test pull-kubevirt-goveralls
/test pull-kubevirt-metrics-lint
/test pull-kubevirt-unit-test-arm64
/test pull-kubevirt-verify-rpms

Use /test all to run the following jobs that were automatically triggered:

pull-kubevirt-apidocs
pull-kubevirt-build
pull-kubevirt-build-arm64
pull-kubevirt-check-tests-for-flakes
pull-kubevirt-check-unassigned-tests
pull-kubevirt-client-python
pull-kubevirt-code-lint
pull-kubevirt-conformance-arm64
pull-kubevirt-e2e-arm64
pull-kubevirt-e2e-k8s-1.29-sig-compute
pull-kubevirt-e2e-k8s-1.29-sig-compute-migrations
pull-kubevirt-e2e-k8s-1.29-sig-monitoring
pull-kubevirt-e2e-k8s-1.29-sig-network
pull-kubevirt-e2e-k8s-1.29-sig-operator
pull-kubevirt-e2e-k8s-1.29-sig-storage
pull-kubevirt-fossa
pull-kubevirt-generate
pull-kubevirt-goveralls
pull-kubevirt-manifests
pull-kubevirt-prom-rules-verify
pull-kubevirt-unit-test
pull-kubevirt-unit-test-arm64
pull-kubevirt-verify-go-mod

In response to this:

/test pull-kubevirt-e2e-k8s-1.28-sig-monitoring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

assafad · 2024-03-20T10:41:36Z

/test pull-kubevirt-e2e-k8s-1.28-sig-monitoring

kubevirt-bot · 2024-03-20T10:41:41Z

@assafad: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-kubevirt-apidocs
/test pull-kubevirt-build
/test pull-kubevirt-build-arm64
/test pull-kubevirt-check-unassigned-tests
/test pull-kubevirt-client-python
/test pull-kubevirt-code-lint
/test pull-kubevirt-e2e-k8s-1.27-sig-compute
/test pull-kubevirt-e2e-k8s-1.27-sig-network
/test pull-kubevirt-e2e-k8s-1.27-sig-operator
/test pull-kubevirt-e2e-k8s-1.27-sig-performance
/test pull-kubevirt-e2e-k8s-1.27-sig-storage
/test pull-kubevirt-e2e-k8s-1.28-sig-compute
/test pull-kubevirt-e2e-k8s-1.28-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-operator
/test pull-kubevirt-e2e-k8s-1.28-sig-storage
/test pull-kubevirt-e2e-k8s-1.29-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-compute
/test pull-kubevirt-e2e-k8s-1.29-sig-compute-migrations
/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring
/test pull-kubevirt-e2e-k8s-1.29-sig-network
/test pull-kubevirt-e2e-k8s-1.29-sig-operator
/test pull-kubevirt-e2e-k8s-1.29-sig-storage
/test pull-kubevirt-e2e-kind-1.27-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-fossa
/test pull-kubevirt-generate
/test pull-kubevirt-manifests
/test pull-kubevirt-prom-rules-verify
/test pull-kubevirt-unit-test
/test pull-kubevirt-verify-go-mod

The following commands are available to trigger optional jobs:

/test build-kubevirt-builder
/test pull-kubevirt-build-s390x
/test pull-kubevirt-check-tests-for-flakes
/test pull-kubevirt-conformance-arm64
/test pull-kubevirt-e2e-arm64
/test pull-kubevirt-e2e-k8s-1.29-sig-compute-realtime
/test pull-kubevirt-e2e-k8s-1.29-sig-compute-root
/test pull-kubevirt-e2e-k8s-1.29-sig-network-multus-v4
/test pull-kubevirt-e2e-k8s-1.29-sig-storage-root
/test pull-kubevirt-e2e-k8s-1.29-single-node
/test pull-kubevirt-e2e-k8s-1.29-swap-enabled
/test pull-kubevirt-e2e-k8s-1.30-sig-compute
/test pull-kubevirt-e2e-k8s-1.30-sig-network
/test pull-kubevirt-e2e-k8s-1.30-sig-operator
/test pull-kubevirt-e2e-k8s-1.30-sig-storage
/test pull-kubevirt-gosec
/test pull-kubevirt-goveralls
/test pull-kubevirt-metrics-lint
/test pull-kubevirt-unit-test-arm64
/test pull-kubevirt-verify-rpms

Use /test all to run the following jobs that were automatically triggered:

pull-kubevirt-apidocs
pull-kubevirt-build
pull-kubevirt-build-arm64
pull-kubevirt-check-tests-for-flakes
pull-kubevirt-check-unassigned-tests
pull-kubevirt-client-python
pull-kubevirt-code-lint
pull-kubevirt-conformance-arm64
pull-kubevirt-e2e-arm64
pull-kubevirt-e2e-k8s-1.29-sig-compute
pull-kubevirt-e2e-k8s-1.29-sig-compute-migrations
pull-kubevirt-e2e-k8s-1.29-sig-monitoring
pull-kubevirt-e2e-k8s-1.29-sig-network
pull-kubevirt-e2e-k8s-1.29-sig-operator
pull-kubevirt-e2e-k8s-1.29-sig-storage
pull-kubevirt-fossa
pull-kubevirt-generate
pull-kubevirt-goveralls
pull-kubevirt-manifests
pull-kubevirt-prom-rules-verify
pull-kubevirt-unit-test
pull-kubevirt-unit-test-arm64
pull-kubevirt-verify-go-mod

In response to this:

/test pull-kubevirt-e2e-k8s-1.28-sig-monitoring

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

assafad · 2024-03-20T10:41:45Z

/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring

assafad · 2024-03-20T14:27:09Z

/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring

assafad · 2024-03-20T15:36:42Z

/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring

enp0s3 · 2024-03-26T09:15:38Z

tests/testsuite/kubevirtresource.go

@@ -198,8 +198,10 @@ func UpdateKubeVirtConfigValue(kvConfig v1.KubeVirtConfiguration) *v1.KubeVirt {
 	patch, err := strategicpatch.CreateTwoWayMergePatch(old, newJson, kv)
 	Expect(err).ToNot(HaveOccurred())

-	kv, err = virtClient.KubeVirt(kv.Namespace).Patch(kv.GetName(), types.MergePatchType, patch, &metav1.PatchOptions{})
-	Expect(err).ToNot(HaveOccurred())
+	Eventually(func() error {


@assafad Can you please explain why this is necessary? IIUC the issue was with handling cluster role bindings

kubevirt-bot · 2024-03-26T11:04:16Z

@assafad: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubevirt-e2e-k8s-1.29-sig-network	`660228a`	link	true	`/test pull-kubevirt-e2e-k8s-1.29-sig-network`
pull-kubevirt-e2e-k8s-1.29-sig-monitoring	`d555a81`	link	true	`/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Signed-off-by: assafad <aadmi@redhat.com>

assafad · 2024-03-26T11:17:01Z

closing in favor of #11506.

kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 19, 2024

kubevirt-bot requested review from kbidarkar and vasiliy-ul March 19, 2024 08:35

kubevirt-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS labels Mar 19, 2024

assafad force-pushed the component-monitoring-test branch from 96d7771 to 660228a Compare March 20, 2024 10:40

kubevirt-bot added size/M and removed size/XS labels Mar 20, 2024

assafad changed the title ~~Reintegrate virtController alerts test~~ Fix test failure due to missing CRBs Mar 20, 2024

kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 24, 2024

assafad marked this pull request as ready for review March 24, 2024 08:13

kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2024

kubevirt-bot requested a review from jean-edouard March 24, 2024 08:13

assafad changed the title ~~Fix test failure due to missing CRBs~~ Fix monitoring test failure due to missing CRBs Mar 25, 2024

enp0s3 reviewed Mar 26, 2024

View reviewed changes

assafad force-pushed the component-monitoring-test branch from 660228a to d555a81 Compare March 26, 2024 09:53

Fix test failure due to missing CRBs

de52207

Signed-off-by: assafad <aadmi@redhat.com>

assafad force-pushed the component-monitoring-test branch from d555a81 to de52207 Compare March 26, 2024 11:07

assafad closed this Mar 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix monitoring test failure due to missing CRBs #11541

Fix monitoring test failure due to missing CRBs #11541

assafad commented Mar 19, 2024 •

edited

kubevirt-bot commented Mar 19, 2024

kubevirt-bot commented Mar 19, 2024

assafad commented Mar 19, 2024

assafad commented Mar 19, 2024

assafad commented Mar 19, 2024

assafad commented Mar 19, 2024

assafad commented Mar 20, 2024

assafad commented Mar 20, 2024

assafad commented Mar 20, 2024

kubevirt-bot commented Mar 20, 2024

assafad commented Mar 20, 2024

kubevirt-bot commented Mar 20, 2024

assafad commented Mar 20, 2024

assafad commented Mar 20, 2024

assafad commented Mar 20, 2024

enp0s3 Mar 26, 2024

kubevirt-bot commented Mar 26, 2024

assafad commented Mar 26, 2024

Fix monitoring test failure due to missing CRBs #11541

Fix monitoring test failure due to missing CRBs #11541

Conversation

assafad commented Mar 19, 2024 • edited

What this PR does

Special notes for your reviewer

Checklist

Release note

kubevirt-bot commented Mar 19, 2024

kubevirt-bot commented Mar 19, 2024

assafad commented Mar 19, 2024

assafad commented Mar 19, 2024

assafad commented Mar 19, 2024

assafad commented Mar 19, 2024

assafad commented Mar 20, 2024

assafad commented Mar 20, 2024

assafad commented Mar 20, 2024

kubevirt-bot commented Mar 20, 2024

assafad commented Mar 20, 2024

kubevirt-bot commented Mar 20, 2024

assafad commented Mar 20, 2024

assafad commented Mar 20, 2024

assafad commented Mar 20, 2024

enp0s3 Mar 26, 2024

Choose a reason for hiding this comment

kubevirt-bot commented Mar 26, 2024

assafad commented Mar 26, 2024

assafad commented Mar 19, 2024 •

edited