Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.1] Deprecate cpu and memory exceeds alerts #11445

Merged
merged 1 commit into from Apr 11, 2024

Conversation

avlitman
Copy link
Contributor

@avlitman avlitman commented Mar 6, 2024

What this PR does / why we need it:
Deprecate the KubeVirtComponentExceedsRequestedCPU and KubeVirtComponentExceedsRequestedMemory alerts.
These alerts are wrong and don't need to be reported to the user.

Which issue(s) this PR fixes:
Jira-Ticket: https://issues.redhat.com/browse/CNV-37900

Special notes for your reviewer:

Release note:

KubeVirtComponentExceedsRequestedCPU and KubeVirtComponentExceedsRequestedMemory alerts are deprecated; they do not indicate a genuine issue.

Signed-off-by: avlitman <alitman@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Mar 6, 2024
@avlitman
Copy link
Contributor Author

avlitman commented Mar 7, 2024

/retest

5 similar comments
@avlitman
Copy link
Contributor Author

avlitman commented Mar 7, 2024

/retest

@avlitman
Copy link
Contributor Author

avlitman commented Mar 7, 2024

/retest

@avlitman
Copy link
Contributor Author

/retest

@avlitman
Copy link
Contributor Author

/retest

@avlitman
Copy link
Contributor Author

/retest

@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

1 similar comment
@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2024
@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

12 similar comments
@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

5 similar comments
@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

@kubevirt-commenter-bot
Copy link

✋🧢

/hold

⚠️ This pull request exceeds the number of retests that are allowed per individual commit.

🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present!

👌 After all issues have been resolved, you can remove the hold on this pull request by commenting /unhold on it.

🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!

Checklist:

✅ your changes compile
✅ no linting errors
✅ no unit test errors
✅ no recurring e2e test errors, i.e. in the check-tests-for-flakes lane
✅ no infrastructure issues, i.e. GitHub Status

💬 How we calculate the number of retests: The number of retest comments are the number of /test or /retest comments after the latest commit only. Note that Phase2 comments are excluded from this number.

@enp0s3
Copy link
Contributor

enp0s3 commented Mar 13, 2024

@machadovilaca Hey, can you please help investigating the failure? maybe some leftover from previous monitoring test spec.

@avlitman
Copy link
Contributor Author

@machadovilaca @enp0s3 I did ran make generate and make all and it passed manually, and I looked at the ci logs it does not seem related to the changed I did in this pr so I'm really not sure..

@enp0s3
Copy link
Contributor

enp0s3 commented Mar 13, 2024

@avlitman It may not be related to your changes but still it can be flaky. The flake could be fixed in main but didn't backport. Note that monitoring lane is not always triggered so it may have been flaky and unnoticed

@machadovilaca
Copy link
Member

looking

@enp0s3
Copy link
Contributor

enp0s3 commented Mar 13, 2024

@avlitman @machadovilaca Please note that the previous ginkgo container errors metrics deals with deleting and creating the virt-operator role binding, it may affect the access of virt-operator to to the api components

@machadovilaca
Copy link
Member

@avlitman @machadovilaca Please note that the previous ginkgo container errors metrics deals with deleting and creating the virt-operator role binding, it may affect the access of virt-operator to to the api components

seems strange, in that case I would expect a fail in both:

_, err = virtClient.RbacV1().ClusterRoleBindings().Create(context.Background(), crb, metav1.CreateOptions{})
			if !errors.IsAlreadyExists(err) {
				util.PanicOnError(err)
			}

and

			waitUntilAlertDoesNotExist(virtClient, virtOperator.downAlert, virtApi.downAlert, virtController.downAlert, virtHandler.downAlert)

the role binding wouldn't have been restored properly, and the alert should still be firing

@machadovilaca
Copy link
Member

@enp0s3 @avlitman #11506

@avlitman
Copy link
Contributor Author

@enp0s3 @avlitman #11506

Thank you for creating a fix. So @enp0s3 let's merge the fix first right?

@dhiller
Copy link
Contributor

dhiller commented Mar 14, 2024

/test pull-kubevirt-goveralls-1.1

@avlitman
Copy link
Contributor Author

avlitman commented Apr 3, 2024

/retest

1 similar comment
@avlitman
Copy link
Contributor Author

/retest

@avlitman
Copy link
Contributor Author

avlitman commented Apr 10, 2024

Hi @enp0s3 monitoring lane succeed any chance you can take a look again? can we close #11506?

@enp0s3
Copy link
Contributor

enp0s3 commented Apr 11, 2024

Hi @enp0s3 monitoring lane succeed any chance you can take a look again? can we close #11506?

@avlitman @machadovilaca I don't think its a good idea to close #11506 unless the situation described there is not correct. However with regards to this PR I think we can merge it since the issue was with the CI.

Copy link
Contributor

@enp0s3 enp0s3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel
/approve

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2024
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enp0s3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2024
@enp0s3
Copy link
Contributor

enp0s3 commented Apr 11, 2024

/retest-required

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Apr 11, 2024

@avlitman: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubevirt-e2e-arm64 5b07175 link false /test pull-kubevirt-e2e-arm64-1.1
pull-kubevirt-check-tests-for-flakes 5b07175 link false /test pull-kubevirt-check-tests-for-flakes-1.1
pull-kubevirt-goveralls 5b07175 link false /test pull-kubevirt-goveralls-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@enp0s3
Copy link
Contributor

enp0s3 commented Apr 11, 2024

/retest-required

@kubevirt-bot kubevirt-bot merged commit 6b6d0a1 into kubevirt:release-1.1 Apr 11, 2024
33 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants