New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.1] Deprecate cpu and memory exceeds alerts #11445
[release-1.1] Deprecate cpu and memory exceeds alerts #11445
Conversation
Signed-off-by: avlitman <alitman@redhat.com>
/retest |
5 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
1 similar comment
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
12 similar comments
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
5 similar comments
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
✋🧢 /hold 🔎 Please check that the changes you committed are fine and that there are no infrastructure issues present! 👌 After all issues have been resolved, you can remove the hold on this pull request by commenting 🙇 Thank you, your friendly referee automation, on behalf of the KubeVirt community!
Checklist:
✅ your changes compile 💬 How we calculate the number of retests: The number of retest comments are the number of |
@machadovilaca Hey, can you please help investigating the failure? maybe some leftover from previous monitoring test spec. |
@machadovilaca @enp0s3 I did ran make generate and make all and it passed manually, and I looked at the ci logs it does not seem related to the changed I did in this pr so I'm really not sure.. |
@avlitman It may not be related to your changes but still it can be flaky. The flake could be fixed in main but didn't backport. Note that monitoring lane is not always triggered so it may have been flaky and unnoticed |
looking |
@avlitman @machadovilaca Please note that the previous ginkgo container |
seems strange, in that case I would expect a fail in both:
and
the role binding wouldn't have been restored properly, and the alert should still be firing |
/test pull-kubevirt-goveralls-1.1 |
/retest |
1 similar comment
/retest |
@avlitman @machadovilaca I don't think its a good idea to close #11506 unless the situation described there is not correct. However with regards to this PR I think we can merge it since the issue was with the CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold cancel
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enp0s3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
@avlitman: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required |
What this PR does / why we need it:
Deprecate the KubeVirtComponentExceedsRequestedCPU and KubeVirtComponentExceedsRequestedMemory alerts.
These alerts are wrong and don't need to be reported to the user.
Which issue(s) this PR fixes:
Jira-Ticket: https://issues.redhat.com/browse/CNV-37900
Special notes for your reviewer:
Release note: