sig-observability: Update ownerships

[machadovilaca]

What this PR does

Before this PR:

We had no assigned observability reviewer, nor approvers/reviewers and sig/observability labeling in observability packages

After this PR:

• @machadovilaca as observability reviewer
• @sradco as observability approver

Owner files in:

• pkg/monitoring
• tests/monitoring
• tests/libmonitoring
• hack/prom-rule-ci

Fixes #

Why we need it and why it was done in this way

The following tradeoffs were made:

The following alternatives were considered:

Links to places where the discussion took place:

Special notes for your reviewer

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

• Design: A design document was considered and is present (link) or not required
• PR: The PR description is expressive enough and will help future contributors
• Code: Write code that humans can understand and Keep it simple
• Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
• Upgrade: Impact of this change on upgrade flows was considered and addressed if required
• Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
• Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
• Community: Announcement to kubevirt-dev was considered

Release note

NONE

/cc @enp0s3 @dhiller @fabiand

[enp0s3]

@machadovilaca Hi, can you please add yourself to these as well:

/hack/prom-rule-ci
/tests/monitoring

[machadovilaca]

@machadovilaca Hi, can you please add yourself to these as well:

/hack/prom-rule-ci
/tests/monitoring

added

[fabiand]

Thanks @machadovilaca

Please

1. extend the PR to also set labels accoridng to sig like here https://github.com/kubevirt/kubevirt/pull/11225/files#diff-c393dd2b18a8a597d895940893e574d6895122c4bf3ce6e2a78dbd9ca0cdd66fR17-R18
2. Updat ethe PR description to be meaningful

[machadovilaca]

@fabiand updated

[iholder101]

Thank you @machadovilaca!

I think it's essential to assign an approver to sig-obvservability as well.
Perhaps @sradco could be a good fit?

[machadovilaca]

@enp0s3 @fabiand can you take a new look?

[enp0s3]

/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enp0s3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [enp0s3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[iholder101]

Looks good to me.
Holding to let @fabiand and others express their opinions and objections, if any.

/lgtm
/hold

[kubevirt-commenter-bot]

Required labels detected, running phase 2 presubmits:
/test pull-kubevirt-e2e-windows2016
/test pull-kubevirt-e2e-kind-1.27-vgpu
/test pull-kubevirt-e2e-kind-sriov
/test pull-kubevirt-e2e-k8s-1.29-ipv6-sig-network
/test pull-kubevirt-e2e-k8s-1.27-sig-network
/test pull-kubevirt-e2e-k8s-1.27-sig-storage
/test pull-kubevirt-e2e-k8s-1.27-sig-compute
/test pull-kubevirt-e2e-k8s-1.27-sig-operator
/test pull-kubevirt-e2e-k8s-1.28-sig-network
/test pull-kubevirt-e2e-k8s-1.28-sig-storage
/test pull-kubevirt-e2e-k8s-1.28-sig-compute
/test pull-kubevirt-e2e-k8s-1.28-sig-operator

[machadovilaca]

ping @fabiand

[fabiand]

Thanks @machadovilaca please link to a SIG Charter proposal as other SIGs have done in this thread: https://groups.google.com/g/kubevirt-dev/c/9hOLqb9W2-Y

[fabiand]

I'm

/hold

ing until then, but generally

/lgtm

[machadovilaca]

sig-observability charter:
mailing list - https://groups.google.com/g/kubevirt-dev/c/9hOLqb9W2-Y
PR - kubevirt/community#282

[fabiand]

/unhold

as a charter got posted

[avlitman]

/cherry-pick release-1.2

[kubevirt-bot]

@avlitman: new pull request created: #11705

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[avlitman]

/cherry-pick release-1.1

[avlitman]

/cherry-pick release-1.0

[kubevirt-bot]

@avlitman: new pull request created: #11706

In response to this:

/cherry-pick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kubevirt-bot]

@avlitman: new pull request created: #11707

In response to this:

/cherry-pick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.