Merge pull request #11249 from machadovilaca/add-sig-observability-to…

…-pkg-monitoring sig-observability: Update ownerships
kubevirt · Apr 3, 2024 · 48f0f07 · 48f0f07
2 parents 93a5fda + 63bb8f1
commit 48f0f07
Show file tree

Hide file tree

Showing 5 changed files with 34 additions and 6 deletions.
diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES
@@ -114,8 +114,10 @@ aliases:
   # Owns the responsibility to keep kubevirt observable by i.e.
   # having mertics, alters, and runbooks.
   #
-  sig-observability-approvers: []
-  sig-observability-reviewers: []
+  sig-observability-approvers:
+    - sradco
+  sig-observability-reviewers:
+    - machadovilaca
 
   #
   # SIG Release

diff --git a/hack/prom-rule-ci/OWNERS b/hack/prom-rule-ci/OWNERS
@@ -0,0 +1,8 @@
+# See the OWNERS docs at https://go.k8s.io/owners
+
+approvers:
+  - sig-observability-approvers
+reviewers:
+  - sig-observability-reviewers
+labels:
+  - sig/observability
diff --git a/pkg/monitoring/OWNERS b/pkg/monitoring/OWNERS
@@ -1,6 +1,8 @@
 # See the OWNERS docs at https://go.k8s.io/owners
 
-filters:
-  ".*":
-    labels:
-      - area/monitoring
+approvers:
+  - sig-observability-approvers
+reviewers:
+  - sig-observability-reviewers
+labels:
+  - sig/observability
diff --git a/tests/libmonitoring/OWNERS b/tests/libmonitoring/OWNERS
@@ -0,0 +1,8 @@
+# See the OWNERS docs at https://go.k8s.io/owners
+
+approvers:
+  - sig-observability-approvers
+reviewers:
+  - sig-observability-reviewers
+labels:
+  - sig/observability
diff --git a/tests/monitoring/OWNERS b/tests/monitoring/OWNERS
@@ -0,0 +1,8 @@
+# See the OWNERS docs at https://go.k8s.io/owners
+
+approvers:
+  - sig-observability-approvers
+reviewers:
+  - sig-observability-reviewers
+labels:
+  - sig/observability