Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prow, labels, github: Add sig/observability label #3345

Merged

Conversation

machadovilaca
Copy link
Member

What this PR does / why we need it:

Add sig/observability label

sig-observability charter: kubevirt/community#282
KubeVirt ownerships: kubevirt/kubevirt#11249

/cc @sradco @dhiller @fabiand

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

Signed-off-by: machadovilaca <machadovilaca@gmail.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Apr 10, 2024
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks @machadovilaca !

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
@kubevirt-bot kubevirt-bot merged commit e8efc2b into kubevirt:main Apr 10, 2024
6 checks passed
@kubevirt-bot
Copy link
Contributor

@machadovilaca: Updated the label-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key labels.yaml using file github/ci/prow-deploy/kustom/base/configs/current/labels/labels.yaml

In response to this:

What this PR does / why we need it:

Add sig/observability label

sig-observability charter: kubevirt/community#282
KubeVirt ownerships: kubevirt/kubevirt#11249

/cc @sradco @dhiller @fabiand

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@machadovilaca machadovilaca deleted the add-sig-observability-label branch April 10, 2024 13:47
Barakmor1 pushed a commit to Barakmor1/project-infra that referenced this pull request Apr 24, 2024
Signed-off-by: machadovilaca <machadovilaca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants