Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this seems fine. My only question is that since this system spec is also used in e2e_node_suite_test.go, whether this implies any particular level of support for docker + zfs.
cc @timothysc @derekwaynecarr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my only confirmation that people are actually using ZFS + Docker + k8s is the issue report that triggered this PR:
kubernetes/kubeadm#930 (comment)
and also this blog post:
https://hackernoon.com/starting-small-with-kubernetes-and-kubeadm-500-containers-6c76454e6e12
so in a way people are already using it, but not sure how a particular level of support can be defined for a Docker graph driver.