New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/e2e_node/system/types_unix: support ZFS #65635
Conversation
Docker validation tests in the case of ZFS used as the graph driver fail due to "zfs" not being present in the default Docker specification. Add "zfs" in the GraphDriver slice.
/test pull-kubernetes-e2e-gce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Needs approval by @kubernetes/sig-node-pr-reviews
/kind bug |
@@ -63,7 +63,7 @@ var DefaultSysSpec = SysSpec{ | |||
RuntimeSpec: RuntimeSpec{ | |||
DockerSpec: &DockerSpec{ | |||
Version: []string{`1\.1[1-3]\..*`, `17\.03\..*`}, // Requires [1.11, 17.03] | |||
GraphDriver: []string{"aufs", "overlay", "overlay2", "devicemapper"}, | |||
GraphDriver: []string{"aufs", "overlay", "overlay2", "devicemapper", "zfs"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this seems fine. My only question is that since this system spec is also used in e2e_node_suite_test.go, whether this implies any particular level of support for docker + zfs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my only confirmation that people are actually using ZFS + Docker + k8s is the issue report that triggered this PR:
kubernetes/kubeadm#930 (comment)
and also this blog post:
https://hackernoon.com/starting-small-with-kubernetes-and-kubeadm-500-containers-6c76454e6e12
so in a way people are already using it, but not sure how a particular level of support can be defined for a Docker graph driver.
While we don't have any e2e testing to validate that ZFS works each release, there are definitely people using it. There is a group of contributors that submit bug-fixes for ZFS to cAdvisor, so I expect zfs to continue to function in future releases. |
The only supported Docker storage driver missing here is /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ConnorDoyle, luxas, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ConnorDoyle @luxas |
Automatic merge from submit-queue (batch tested with PRs 65348, 65599, 65635, 65688, 65691). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
Docker validation tests in the case of ZFS used as the graph driver
fail due to "zfs" not being present in the default Docker specification.
Add "zfs" in the GraphDriver slice.
kubeadm relies on the
DockerValidator
and pre-flight checks would fail if the user is using ZFS.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Updates kubernetes/kubeadm#930
Special notes for your reviewer:
NONE
/cc @kubernetes/sig-node-pr-reviews
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews
/cc @kvaps (reported by)
/area node-e2e
/area kubeadm
Release note: