Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRA: structured parameters #123516

Merged
merged 18 commits into from Mar 8, 2024
Merged

DRA: structured parameters #123516

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
eb1470d
scheduler: fix assume cache with no index
pohly Feb 20, 2024
39bbced
dra api: add structured parameters
pohly Feb 14, 2024
2e34e18
node authorizer: lock down access for NodeResourceSlice
pohly Jan 24, 2024
a92d2a4
noderestriction admission: lock down create of NodeResourceSlice
pohly Jan 24, 2024
096e948
dra scheduler: support structured parameters
pohly Feb 16, 2024
d4d5ade
dra: add "named resources" structured parameter model
pohly Feb 23, 2024
4ed2b3e
scheduler_perf: test DRA with structured parameters
pohly Feb 20, 2024
6f1ddfc
kubelet: support structured parameters for preparing resources
pohly Feb 20, 2024
3de376e
dra controller: support structured parameters
pohly Feb 21, 2024
5e40afc
dra testing: add tests for structured parameters
pohly Dec 11, 2023
d59676a
dra kubelet: publish NodeResourceSlices
pohly Feb 26, 2024
234dc1f
dra e2e: run more test scenarios with structured parameters
pohly Feb 26, 2024
42ee56f
dra api: implement semver attribute value type
pohly Mar 4, 2024
0b6a0d6
dra api: rename NodeResourceSlice -> ResourceSlice
pohly Mar 7, 2024
2c6246c
dra e2e: move ResourceSlice test
pohly Mar 7, 2024
251b385
dra scheduler: consider in-flight allocation for resource calculation
pohly Mar 7, 2024
7f5566a
dra e2e: enable more tests for usage with structured parameters
pohly Mar 7, 2024
6a361e1
dra api: enable new CEL features by faking their version
pohly Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions api/api-rules/violation_exceptions.list
View file
Open in desktop
Expand Up @@ -51,6 +51,13 @@ API rule violation: names_match,k8s.io/api/core/v1,RBDVolumeSource,RadosUser
API rule violation: names_match,k8s.io/api/core/v1,VolumeSource,CephFS
API rule violation: names_match,k8s.io/api/core/v1,VolumeSource,StorageOS
API rule violation: names_match,k8s.io/api/networking/v1alpha1,ServiceCIDRSpec,CIDRs
API rule violation: names_match,k8s.io/api/resource/v1alpha2,NamedResourcesAttributeValue,BoolValue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have violations in new APIs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there's a conflict in the Go code between the String field and the required String method. We could have renamed just that one field to Str (or something like it), but doing it consistently for all fields seemed better.

API rule violation: names_match,k8s.io/api/resource/v1alpha2,NamedResourcesAttributeValue,IntSliceValue
API rule violation: names_match,k8s.io/api/resource/v1alpha2,NamedResourcesAttributeValue,IntValue
API rule violation: names_match,k8s.io/api/resource/v1alpha2,NamedResourcesAttributeValue,QuantityValue
API rule violation: names_match,k8s.io/api/resource/v1alpha2,NamedResourcesAttributeValue,StringSliceValue
API rule violation: names_match,k8s.io/api/resource/v1alpha2,NamedResourcesAttributeValue,StringValue
API rule violation: names_match,k8s.io/api/resource/v1alpha2,NamedResourcesAttributeValue,VersionValue
API rule violation: names_match,k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1,JSONSchemaProps,Ref
API rule violation: names_match,k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1,JSONSchemaProps,Schema
API rule violation: names_match,k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1,JSONSchemaProps,XEmbeddedResource
Expand Down
60 changes: 60 additions & 0 deletions api/discovery/aggregated_v2beta1.json
View file
Open in desktop
Expand Up @@ -1926,6 +1926,26 @@
"watch"
]
},
{
"resource": "resourceclaimparameters",
"responseKind": {
"group": "",
"kind": "ResourceClaimParameters",
"version": ""
},
"scope": "Namespaced",
"singularResource": "resourceclaimparameters",
"verbs": [
"create",
"delete",
"deletecollection",
"get",
"list",
"patch",
"update",
"watch"
]
},
{
"resource": "resourceclaims",
"responseKind": {
Expand Down Expand Up @@ -2000,6 +2020,46 @@
"update",
"watch"
]
},
{
"resource": "resourceclassparameters",
"responseKind": {
"group": "",
"kind": "ResourceClassParameters",
"version": ""
},
"scope": "Namespaced",
"singularResource": "resourceclassparameters",
"verbs": [
"create",
"delete",
"deletecollection",
"get",
"list",
"patch",
"update",
"watch"
]
},
{
"resource": "resourceslices",
"responseKind": {
"group": "",
"kind": "ResourceSlice",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the KEP to capture the name change and other deviations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, absolutely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See kubernetes/enhancements#4561

"version": ""
},
"scope": "Cluster",
"singularResource": "resourceslice",
"verbs": [
"create",
"delete",
"deletecollection",
"get",
"list",
"patch",
"update",
"watch"
]
}
],
"version": "v1alpha2"
Expand Down
51 changes: 51 additions & 0 deletions api/discovery/apis__resource.k8s.io__v1alpha2.json
View file
Open in desktop
Expand Up @@ -31,6 +31,23 @@
"update"
]
},
{
"kind": "ResourceClaimParameters",
"name": "resourceclaimparameters",
"namespaced": true,
"singularName": "resourceclaimparameters",
"storageVersionHash": "DWM408h+ZHE=",
"verbs": [
"create",
"delete",
"deletecollection",
"get",
"list",
"patch",
"update",
"watch"
]
},
{
"kind": "ResourceClaim",
"name": "resourceclaims",
Expand Down Expand Up @@ -92,6 +109,40 @@
"update",
"watch"
]
},
{
"kind": "ResourceClassParameters",
"name": "resourceclassparameters",
"namespaced": true,
"singularName": "resourceclassparameters",
"storageVersionHash": "MDq5XoTnXWQ=",
"verbs": [
"create",
"delete",
"deletecollection",
"get",
"list",
"patch",
"update",
"watch"
]
},
{
"kind": "ResourceSlice",
"name": "resourceslices",
"namespaced": false,
"singularName": "resourceslice",
"storageVersionHash": "IECvOcO76kw=",
"verbs": [
"create",
"delete",
"deletecollection",
"get",
"list",
"patch",
"update",
"watch"
]
}
]
}