New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRA: structured parameters #123516
DRA: structured parameters #123516
Changes from all commits
eb1470d
39bbced
2e34e18
a92d2a4
096e948
d4d5ade
4ed2b3e
6f1ddfc
3de376e
5e40afc
d59676a
234dc1f
42ee56f
0b6a0d6
2c6246c
251b385
7f5566a
6a361e1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1926,6 +1926,26 @@ | |
"watch" | ||
] | ||
}, | ||
{ | ||
"resource": "resourceclaimparameters", | ||
"responseKind": { | ||
"group": "", | ||
"kind": "ResourceClaimParameters", | ||
"version": "" | ||
}, | ||
"scope": "Namespaced", | ||
"singularResource": "resourceclaimparameters", | ||
"verbs": [ | ||
"create", | ||
"delete", | ||
"deletecollection", | ||
"get", | ||
"list", | ||
"patch", | ||
"update", | ||
"watch" | ||
] | ||
}, | ||
{ | ||
"resource": "resourceclaims", | ||
"responseKind": { | ||
|
@@ -2000,6 +2020,46 @@ | |
"update", | ||
"watch" | ||
] | ||
}, | ||
{ | ||
"resource": "resourceclassparameters", | ||
"responseKind": { | ||
"group": "", | ||
"kind": "ResourceClassParameters", | ||
"version": "" | ||
}, | ||
"scope": "Namespaced", | ||
"singularResource": "resourceclassparameters", | ||
"verbs": [ | ||
"create", | ||
"delete", | ||
"deletecollection", | ||
"get", | ||
"list", | ||
"patch", | ||
"update", | ||
"watch" | ||
] | ||
}, | ||
{ | ||
"resource": "resourceslices", | ||
"responseKind": { | ||
"group": "", | ||
"kind": "ResourceSlice", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we update the KEP to capture the name change and other deviations? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, absolutely. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
"version": "" | ||
}, | ||
"scope": "Cluster", | ||
"singularResource": "resourceslice", | ||
"verbs": [ | ||
"create", | ||
"delete", | ||
"deletecollection", | ||
"get", | ||
"list", | ||
"patch", | ||
"update", | ||
"watch" | ||
] | ||
} | ||
], | ||
"version": "v1alpha2" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have violations in new APIs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because there's a conflict in the Go code between the
String
field and the requiredString
method. We could have renamed just that one field toStr
(or something like it), but doing it consistently for all fields seemed better.