Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PetSet to StatefulSet #35534

Closed
11 tasks done
janetkuo opened this issue Oct 25, 2016 · 31 comments
Closed
11 tasks done

Rename PetSet to StatefulSet #35534

janetkuo opened this issue Oct 25, 2016 · 31 comments
Assignees
@janetkuo
Labels
area/stateful-apps sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Milestone
v1.6

Comments

@janetkuo
Copy link
Member

janetkuo commented Oct 25, 2016 •
edited

A list of things need to be changed for renaming PetSet. Feel free to extend the list:

Pre code freeze:

Post code freeze:

Move to 1.6:

  • File names (include petset controller, petset tests) & import path (do we care?)
    • we care about e2e test file names

Open questions:

  • How do we rename “pets”? We can just call them "pods"
  • Upgrade tests will be broken?

Ref #35182
cc @erictune @foxish @bprashanth @kubernetes/sig-apps @chrislovecnm @jimmycuadra
@janetkuo janetkuo added area/stateful-apps sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Oct 25, 2016
@janetkuo janetkuo added this to the v1.5 milestone Oct 25, 2016
@janetkuo janetkuo self-assigned this Oct 25, 2016
@hjacobs
Copy link

hjacobs commented Oct 25, 2016

OMG, after the comments in #27430 I would have thought there would be some consideration, but here you go... (I can live with the rename, but I'm also somehow disappointed 😞 ).

@bprashanth
Copy link
Contributor

I noticed you already have a pr for the first, thanks! We should focus on nailing the api change before code freeze.

@justinsb
Copy link
Member

We should probably wait for the community to determine a name, right?

@bprashanth
Copy link
Contributor

I think the poll is closed

@justinsb
Copy link
Member

Perhaps, but the poll results have not been computed: #27430 (comment)

Also, presumably we should check to see if there are objections to the winner, unless you want to do this twice :-)

Also, perhaps the reason PetSet was excluded was because we are now going to ask the community to vote on "PetSet vs winner".

@aecolley aecolley mentioned this issue Oct 25, 2016
Closed
@chrislovecnm
Copy link
Contributor

File names we care, impacts e2e tests

@soltysh soltysh mentioned this issue Oct 26, 2016
Closed
@chrislovecnm
Copy link
Contributor

@justinsb it has been renamed ;) It is done, now let's rename this poodle. Oh wait StatefulSet

@chrislovecnm
Copy link
Contributor

@janetkuo I know we have code that references filenames as well. C* e2e tests for instance.

@chrislovecnm
Copy link
Contributor

@janetkuo do we want to put blog posts in here as well. Probably want to add a note about the name change to some of the posts on our blog.

@janetkuo janetkuo mentioned this issue Oct 27, 2016
Merged
@bprashanth bprashanth mentioned this issue Oct 27, 2016
Merged
@m1093782566
Copy link
Contributor

m1093782566 commented Oct 27, 2016 •
edited

@janetkuo I am working on improving PetSet(StatefulSet) test coverage, I will be glad to coordinate with you and do some help if you need :)

@janetkuo janetkuo mentioned this issue Oct 27, 2016
Merged
@janetkuo
Copy link
Member Author

@chrislovecnm thanks for the suggestions! Issue description updated. @m1093782566 thanks please refer to #35663 and #35731 for renaming PetSet and moving it to v1beta1

@chrislovecnm
Copy link
Contributor

@janetkuo can we make reference in the Cassandra example that Stateful set is the feature previously known as PetSet? I don't have time for updates as I have a week before kubecon :( Too much code to write.

k8s-github-robot pushed a commit that referenced this issue Oct 28, 2016
Merge pull request #35663 from janetkuo/statefulset
e37b7cb 
Automatic merge from submit-queue

Rename PetSet to StatefulSet

<!--  Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md
2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md
3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes
-->

**What this PR does / why we need it**: #35534

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*: 

**Special notes for your reviewer**: cc @erictune @foxish @kubernetes/sig-apps @ymqytw 

**Release note**:
<!--  Steps to write your release note:
1. Use the release-note-* labels to set the release note state (if you have access) 
2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. 
-->
```release-note
```
@jimmycuadra jimmycuadra mentioned this issue Oct 28, 2016
Merged
@janetkuo
Copy link
Member Author

@janetkuo can we make reference in the Cassandra example that Stateful set is the feature previously known as PetSet? I don't have time for updates as I have a week before kubecon :( Too much code to write.

@chrislovecnm - @jimmycuadra has a PR for it (#35776)

@chrislovecnm
Copy link
Contributor

@janetkuo thanks ;) Already commented on it

@janetkuo
Copy link
Member Author

We should still mention that StatefulSet is formerly known as PetSet in types.go and in StatefulSet doc, so that if people search for "PetSet" or only know PetSet, they can still find it.

@fabxc fabxc mentioned this issue Nov 2, 2016
Closed
@janetkuo
Copy link
Member Author

janetkuo commented Nov 4, 2016

Dashboard needs to be updated as well.

@chrislovecnm
Copy link
Contributor

@janetkuo are your checkmarks on top up to date?

k8s-github-robot pushed a commit that referenced this issue Nov 6, 2016
Merge pull request #35776 from jimmycuadra/petset-rename-docs-examples
b75c3a4 
Automatic merge from submit-queue

Rename PetSet to StatefulSet in docs and examples.

**What this PR does / why we need it**: Addresses some of the pre-code-freeze changes for implementing the PetSet --> StatefulSet rename. (#35534)

**Special notes for your reviewer**: This PR only changes docs and examples, as #35731 hasn't been merged yet and I don't want to create merge conflicts. I'll open another PR for any remaining code changes needed after that PR is merged. /cc @erictune @janetkuo @chrislovecnm
@chrislovecnm
Copy link
Contributor

#36323 is blowing up. @janetkuo @bprashanth did we not merge correctly?

@jimmycuadra
Copy link
Contributor

#36418 will fix #36323. Waiting for someone to review/merge.

@janetkuo
Copy link
Member Author

janetkuo commented Nov 8, 2016

@chrislovecnm this happened because example e2e tests aren't blocking submit queue (so it's failing but unnoticed)

@chrislovecnm
Copy link
Contributor

chrislovecnm commented Nov 9, 2016 •
edited

@janetkuo / @jimmycuadra and another #36469

@jimmycuadra not sure if you have dealt with flakes before, but we should have multiple tickets open because of this. Please track down the filename that is blowing up in tickets and ensure those are linked and closed to the PR.

@janetkuo PR is merged, who can validate that the e2e tests are un-flaked :) I would actually love to learn how to validate that myself.

@foxish
Copy link
Contributor

foxish commented Nov 9, 2016

It appears that the cassandra flakes are fixed. I'll take a look at the other long failing spark e2e test in #36102 today.

@enisoc enisoc mentioned this issue Nov 10, 2016
Closed
@bryk
Copy link
Contributor

bryk commented Nov 18, 2016

UI rename done.

@dims
Copy link
Member

dims commented Nov 18, 2016

@janetkuo : would you mark this as non-release-blocker or release-blocker as appropriate please? (by end of day today - Nov 18)

@chrislovecnm
Copy link
Contributor

chrislovecnm commented Nov 18, 2016 •
edited

Ping @janetkuo ;)

@erictune
Copy link
Member

Filenames can move to 1.6.

@dims
Copy link
Member

dims commented Dec 9, 2016

@janetkuo @janetkuo Is it appropriate to move this to the next milestone? (and remove the non-release-blocker tag as well)

@janetkuo janetkuo modified the milestones: v1.6, v1.5 Dec 15, 2016
@janetkuo
Copy link
Member Author

  • Helm Charts in incubator that currently use petSet need to be renamed and tested against a 1.5 cluster, once a beta with the new name is available, and they need to be documented as requiring 1.5 cluster to work.

@viglesiasce are you working on this one?

@niemyjski
Copy link

Any word when StatefulSets will be stable? I see mention of beta in 1.5 and this issue and then this is tagged in for 1.6 as well.

@smarterclayton
Copy link
Contributor

smarterclayton commented Dec 31, 2016 via email

@resouer resouer mentioned this issue Jan 16, 2017
Merged
liggitt pushed a commit to liggitt/kubernetes that referenced this issue Jan 17, 2017
Merge pull request kubernetes#39939 from resouer/statefulset
c0a1fa7 
Automatic merge from submit-queue (batch tested with PRs 34763, 38706, 39939, 40020)

Use Statefulset instead in e2e and controller

Quick fix ref: kubernetes#35534

We should finish the issue to meet v1.6 milestone.
@janetkuo
Copy link
Member Author

janetkuo commented Feb 8, 2017

All the work was done, closing

@janetkuo janetkuo closed this as completed Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janetkuo janetkuo

Labels
area/stateful-apps sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Projects
None yet
Milestone
v1.6
Development

No branches or pull requests