Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track PetSet rename to StateFul set #21

Closed
fabxc opened this issue Nov 2, 2016 · 9 comments
Closed

Track PetSet rename to StateFul set #21

fabxc opened this issue Nov 2, 2016 · 9 comments

Comments

@fabxc
Copy link
Contributor

fabxc commented Nov 2, 2016

x-ref: kubernetes/kubernetes#35534

Pet Sets will be renamed to Stateful Sets.
We'll have to figure out whether we breakingly move forward or adapt the operators behavior based on the used cluster version. If it's merely a rename we should be able to handle it gracefully.

@fabxc
Copy link
Contributor Author

fabxc commented Nov 28, 2016

In 1.5 apps/v1alpha/PetSet will be deleted. Upgrade documentation exists but will require user interaction.

Best course of action seems to be having one operator release for pre-1.5 and one for 1.5 onwards.

@kennethredler
Copy link

kennethredler commented Dec 15, 2016

Is anyone working this issue now that Kube 1.5(.1 even) is out?

@brancz
Copy link
Contributor

brancz commented Dec 15, 2016

@kennethredler The migration to StatefulSets in terms of the operator code will be very easy, it's really just replacing the object kind and apiVersion. The operational part is a bit more complicated though, as if you had the PetSets before then you need to shutdown the operator, upgrade the PetSets to StatefulSets and then start the operator version that uses StatefulSets instead. The question is should we keep maintaining a version utilizing PetSets to allow 1.4.x users to get started as well. Personally that seems like a rabbit hole and if you have a self hosted cluster it should be easy enough to upgrade. Additionally if your deployment does not have high SLA requirements it might even be ok to just delete all your Prometheus/Alertmanager deployments and recreate them with the new version of the operator.

@brancz
Copy link
Contributor

brancz commented Dec 15, 2016

@kennethredler to answer your original question, I have not started working on it yet, but will very soon

@janwillies
Copy link

with latest minikube-0.14.0 (defaults to kube-1.5) the prometheus-operator fails to create pods:

$ kubectl create -f https://coreos.com/operators/prometheus/latest/prometheus-k8s.yaml
$ kubectl logs prometheus-operator-478913231-hd9bw
E1218 09:51:04.412423       1 reflector.go:214] github.com/coreos/prometheus-operator/vendor/k8s.io/client-go/1.5/tools/cache/reflector.go:109: Failed to list *v1alpha1.PetSet: the server could not find the requested resource

@haf
Copy link

haf commented Dec 28, 2016

Stateful is a single word so the title of this issue is wrong?

@kennethredler
Copy link

If I read CHANGELOG.md correctly, this can be closed as fixed in 0.2.0, right?

@fabxc
Copy link
Contributor Author

fabxc commented Jan 4, 2017

Correct, thanks.

@fabxc fabxc closed this as completed Jan 4, 2017
@kennethredler
Copy link

Thank you!!!

brancz pushed a commit to brancz/prometheus-operator that referenced this issue Apr 16, 2019
…rfile

rename dockerfiles to follow current recommendations
philipgough pushed a commit to philipgough/prometheus-operator that referenced this issue Feb 14, 2024
* Updated COMPONENT_VERSION file for release-2.8

Signed-off-by: dislbenn <dbennett@redhat.com>

* added COMPONENT_NAME file to repo

Signed-off-by: dislbenn <dbennett@redhat.com>

Signed-off-by: dislbenn <dbennett@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants