Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): add bannedSeller label for stores #173

Merged
merged 15 commits into from
Sep 21, 2020
Merged

feat(store): add bannedSeller label for stores #173

merged 15 commits into from
Sep 21, 2020

Conversation

geman220
Copy link
Contributor

@geman220 geman220 commented Sep 21, 2020

Description

  • Adding bannedSeller for Amazon to reduce false-positives from scalpers. One potential was to only allow Amazon as a known seller, but with different vendors, and even different names for official Amazon retail, it would be just as difficult to track legitimate sales against scalpers. I figured banning known scalpers is probably safer than trying to anticipate known good sellers.
  • Adding try varying your search terms to bandh.ts since there were a ton of 404 redirects coming up suddenly spamming the bot.
  • Adding error reaching the evga website to evga.ts to avoid false positives from another hug of death.

Work around solution for #165 fixes #142

Testing

  • Tested with DEBUG card using amazon.com as the bannedSeller and got the correct warn that a banned seller was detected.

New dependencies

None

@geman220 geman220 requested a review from jef as a code owner September 21, 2020 19:44
@geman220 geman220 mentioned this pull request Sep 21, 2020
@geman220 geman220 linked an issue Sep 21, 2020 that may be closed by this pull request
@geman220 geman220 linked an issue Sep 21, 2020 that may be closed by this pull request
jef
jef previously approved these changes Sep 21, 2020
@@ -95,7 +95,8 @@ export const Amazon: Store = {
],
labels: {
captcha: ['enter the characters you see below'],
outOfStock: ['currently unavailable', 'available from these sellers']
outOfStock: ['currently unavailable', 'available from these sellers'],
bannedSeller: ['sports authentics', 'raccoon capitalist', 'gigaparts']
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Let's make this an environment variable at some point as well!

@jef jef changed the title Adding bannedSeller label for Amazon (or other retailers if needed) feat(store): add bannedSeller label for stores Sep 21, 2020
@jef jef merged commit 71c6774 into jef:main Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum Price Limit False positives for bhphotovideo and newegg
2 participants