Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum Price Limit #165

Closed
AidanHockey5 opened this issue Sep 21, 2020 · 3 comments · Fixed by #173
Closed

Maximum Price Limit #165

AidanHockey5 opened this issue Sep 21, 2020 · 3 comments · Fixed by #173
Assignees

Comments

@AidanHockey5
Copy link

Description

Only send an alert if an in-stock card is at or below a defined target price. This will reduce the amount of false-positives from various marketplace sellers listing their cards for unreasonable prices. A few sellers on Amazon seem to be notorious for this.

@jef
Copy link
Owner

jef commented Sep 21, 2020

This is going to be solved by parsing the selectors and getting prices. This will be an overall improvement on speed, price filtering and various other things.

This will be top priority on my workload.

Thanks!

@designgears
Copy link
Contributor

Preferably this would have pricing set on each product with the option to set a price margin in the env so we can customize it.

@geman220
Copy link
Contributor

A PR for a simliar concept has been submitted #173. Instead of setting prices, it will allow sellers to be banned from the bot. For example, Sports Authentics is a vendor that keeps triggering the bot. I agree filtering by price limit is a better overall solution, but this PR should at least eliviate false-positives from Amazon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants