Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positives for bhphotovideo and newegg #142

Closed
aTimetochill opened this issue Sep 20, 2020 · 12 comments · Fixed by #173
Closed

False positives for bhphotovideo and newegg #142

aTimetochill opened this issue Sep 20, 2020 · 12 comments · Fixed by #173
Assignees

Comments

@jef
Copy link
Owner

jef commented Sep 21, 2020

B&H will provide problems throughout the weekend since they observe the Sabbath. As for Newegg, not so sure. Screenshots would be helpful here as getting any sort of patterns to remove them would be necessary.

@jef jef added the need info label Sep 21, 2020
@aTimetochill
Copy link
Author

Thanks. I'm turning on screenshots and will add them if I run into more false positives.

@jef
Copy link
Owner

jef commented Sep 21, 2020

Thank you :)

@whoisjordangarcia
Copy link
Contributor

@jef these were the false positives.

Newegg -
success-1600646869836

B&H -
success-1600647404894

@serg06
Copy link
Contributor

serg06 commented Sep 21, 2020

Here's another false positive I got for B&H:

success-1600647018781

@AlpacaDesu
Copy link

success-1600674616432
^ False positive for Newegg. Same as what @arickho encountered :)

@aTimetochill
Copy link
Author

success-1600673900329

@g1forfun
Copy link
Contributor

False positive I just got for Newegg
success-1600720891397

@g1forfun
Copy link
Contributor

False positive from b&h, this is the screenshot it took:
success-1600720612314

@geman220
Copy link
Contributor

These have been resolved except the latest B&H which will be resolved with #173

@aharris02
Copy link

aharris02 commented Sep 21, 2020

I got a false positive off a unique newegg view w/ popup.
success-1600727515436

Would it be easier to find the "in stock" text for each store and look for that, rather than looking for the "out of stock" text, which is complicated by site outages, captcha, etc?

@jef
Copy link
Owner

jef commented Sep 21, 2020

Yeah! There is a PR that should address this:

#141

@jef jef closed this as completed in #173 Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants