Check cairo supports x11 server #4434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uhm... since this test failure only occurred with gcc and not with clang, I am going to assume that this is just a flaky test and not caused by this PR. |
This commits adds code to create a cairo surface for the root window during startup. If this check fails, i3 fails with an error message, because it is very likely that all rendering will fail later on. I only say "very likely", because for later drawing a visual is selected by get_visualtype_by_id(get_visualid_by_depth(win_depth)), i.e. depending on the depth of actual windows. This can still end up picking a visual that cairo cannot work with. However, if cairo cannot even work with the root window's visual, it is very likely that everything else will also fail. Thus, this check should at least help somewhat. Signed-off-by: Uli Schlachter <psychon@znc.in>
A X11 server with a bit depth of eight is highly unusual and is likely not supported by most code out there, including cairo. Just 256 colors?! Thus, this commit changes complete-run.pl to use the more usual depth of 24. This makes Xvfb use 32 bits per pixel, which is also "more usual". Signed-off-by: Uli Schlachter <psychon@znc.in>
orestisfl
force-pushed
the
check-cairo-supports-X11-server
branch
from
0952437
to
f7e4f4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new version of #4433. Sorry for accidentally closing that PR. Since GitHub did not see the newest commits, I wanted to force-push something else and then push the current state of the branch again. Turns out that pushing
nextautomatically closed the PR with no way to opening again (or at least I am not seeing the way).