Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check cairo supports x11 server #4434

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Check cairo supports x11 server #4434

wants to merge 2 commits into from

Commits on Sep 9, 2021

  1. Check if cairo can work with the X11 server 

    This commits adds code to create a cairo surface for the root window
during startup. If this check fails, i3 fails with an error message,
because it is very likely that all rendering will fail later on.

I only say "very likely", because for later drawing a visual is selected
by get_visualtype_by_id(get_visualid_by_depth(win_depth)), i.e.
depending on the depth of actual windows. This can still end up picking
a visual that cairo cannot work with. However, if cairo cannot even work
with the root window's visual, it is very likely that everything else
will also fail. Thus, this check should at least help somewhat.

Signed-off-by: Uli Schlachter <psychon@znc.in>
    @psychon @orestisfl
    psychon authored and orestisfl committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    016017b View commit details
    Browse the repository at this point in the history

  2. complete-run: Run Xvfb with depth 24 

    A X11 server with a bit depth of eight is highly unusual and is likely
not supported by most code out there, including cairo. Just 256 colors?!
Thus, this commit changes complete-run.pl to use the more usual depth of
24. This makes Xvfb use 32 bits per pixel, which is also "more usual".

Signed-off-by: Uli Schlachter <psychon@znc.in>
    @psychon @orestisfl
    psychon authored and orestisfl committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    f7e4f4e View commit details
    Browse the repository at this point in the history