Skip to content

Commit

Permalink
complete-run: Run Xvfb with depth 24
Browse files Browse the repository at this point in the history
A X11 server with a bit depth of eight is highly unusual and is likely
not supported by most code out there, including cairo. Just 256 colors?!
Thus, this commit changes complete-run.pl to use the more usual depth of
24. This makes Xvfb use 32 bits per pixel, which is also "more usual".

Signed-off-by: Uli Schlachter <psychon@znc.in>
  • Loading branch information
psychon authored and orestisfl committed Sep 9, 2021
1 parent 016017b commit f7e4f4e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion testcases/complete-run.pl.in
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ if ($options{xvfb}) {
# parent when ready, so that the wait call will be interrupted. We
# can’t implement this in Perl, as Perl’s waitpid transparently
# handles -EINTR.
exec('/bin/sh', '-c', qq|trap "exit" INT; trap : USR1; (trap '' USR1; exec Xvfb :$n -screen 0 640x480x8 -nolisten tcp) & PID=\$!; wait; if ! kill -0 \$PID 2>/dev/null; then echo 1:\$PID > $path; else echo 0:\$PID > $path; wait \$PID; fi|);
exec('/bin/sh', '-c', qq|trap "exit" INT; trap : USR1; (trap '' USR1; exec Xvfb :$n -screen 0 640x480x24 -nolisten tcp) & PID=\$!; wait; if ! kill -0 \$PID 2>/dev/null; then echo 1:\$PID > $path; else echo 0:\$PID > $path; wait \$PID; fi|);
die "exec: $!";
}
chomp(my $kill = slurp($path));
Expand Down

0 comments on commit f7e4f4e

Please sign in to comment.