Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix people dropdown filter without defined keys #6965

Merged
merged 6 commits into from
Apr 24, 2024

Conversation

yurabakhtin
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch if no hotfix
  • All tests are passing
  • Changelog was modified

Other information:
#6961

@yurabakhtin yurabakhtin requested a review from luke- April 22, 2024 17:46
@yurabakhtin yurabakhtin linked an issue Apr 22, 2024 that may be closed by this pull request
Copy link

what-the-diff bot commented Apr 22, 2024

PR Summary

  • Issue Resolution
  • Updated getSelectItems method in CheckboxList.php and Select.php
    • This update ensures key-value pairs under options are handled correctly.
  • New validateOptions method in Select.php
    • A new method added for verifying that options match the correct format (Key=>Value).
  • Bug Fix in PeopleFilterPicker.php
    • Fixed a bug that was not ignoring empty or null items, thereby improving reliability.
  • Update in humhub.ui.picker.js
    • Improved the templateResult method to correctly handle cases where item ids could be empty.

@luke- luke- added this pull request to the merge queue Apr 24, 2024
Merged via the queue into develop with commit a3072f9 Apr 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile Dropdown - without key syntax - strange behavior
2 participants