Profile Dropdown - without key syntax - strange behavior

[luke-]

Related: #6960 (comment)
Directory Loader

[luke-]

Branch: Develop please

[yurabakhtin]

@luke- PR #6965: I don't think we should use a value as key for case when it is not defined, because it may breaks profiles which were stored before. For example, if the options were defined as:

Male
Female
Diverse

then it works as array with autoincremented keys started with 0:

0 => Male
1 => Female
2 => Diverse

so some profiles were strored with gender = 0 and it worked well except of the People Filter.
The "loading" error was there because of this JS code, i.e. the loader is visible there instead of expected title "Male".

The PR fixes the filter issue, it can be merged, but maybe we should either add an additional info in the field hint One option per line. Key=>Value Format (e.g. yes=>Yes) or restrict for saving it without keys:

[luke-]

@yurabakhtin Ok got it, a validator for the field (check for keys) would probably be the cleanest solution. Can you please implement this?

[yurabakhtin]

@luke- I have added the validation in the commit 922b430:

But I have also detected the same hint we have for the profile type "Checkbox List":

and this type already uses a Value as Key when it is not defined, the code is here .
So here I am a bit confused, because I don't think we should restrict the "Checkbox List" field as I have done for the "Select" field, because such fields were stored in DB with using Values as Keys. Maybe we should update the hint of the "Checkbox List" field to inform the format may be without Keys. Of course better is to keep the same format and same validation for these fields, but in such case we should implement a migration to fix all stored wrong keys.

[luke-]

@yurabakhtin I would prefer if we align CheckboxList and SelectList and use the same validation and saved data keys here. Then we could also allow the type to be changed in future.

Would you like to customize the checkboxes and migrate the data?

[yurabakhtin]

@luke-

Would you like to customize the checkboxes and migrate the data?

Done in the commit 5710f77.
Options will be fixed by new migration with this way depending on field type:

[luke-]

@yurabakhtin Thanks, good solution!