Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabled in IE8 #327

Closed
wants to merge 1 commit into from
Closed

Fix disabled in IE8 #327

wants to merge 1 commit into from

Conversation

abombss
Copy link

@abombss abombss commented Oct 30, 2011

Fixes bug in IE8 with attr 'disabled' introduced in #67 not working properly, the recommended jquery solution is to use prop instead of attr.

…working properly, the recommended jquery solution is to use prop instead of attr.
@pfiller
Copy link
Contributor

pfiller commented Nov 2, 2011

Using the prop() function would cause jQuery 1.4 to no longer be supported. A more backwards-compatible methodology would be to access the property directly:

@is_disabled = @form_field_jq[0].disabled

Most references to attr in Chosen should probably be removed as a result of this method change in jQuery 1.6. I've gone ahead and committed this change in 9bc5fdc. Let me know if you're still seeing problems in IE8.

@abombss
Copy link
Author

abombss commented Nov 2, 2011

I actually just ran some more tests on my behavior and I see it was an
issue with how I was setting the disabled attribute in IE. I was using
$.attr('disabled', '') which worked in chrome & FF but not IE. I need to
explicitly be using $.removeAttr('disabled')

This issue can be closed.

On Wed, Nov 2, 2011 at 11:46 AM, Patrick Filler <
reply@reply.github.com>wrote:

Using the prop() function would cause jQuery 1.4 to no longer be
supported. A more backwards-compatible methodology would be to access the
property directly:

@is_disabled = @form_field_jq[0].disabled

Most references to attr in Chosen should probably be removed as a result
of this method change in jQuery 1.6. I've gone ahead and committed this
change in 9bc5fdc. Let me know if you're still seeing problems in IE8.

Reply to this email directly or view it on GitHub:
#327 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants