Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chosen and jQuery prop() vs attr() #334

Closed
pfiller opened this issue Nov 2, 2011 · 0 comments
Closed

Chosen and jQuery prop() vs attr() #334

pfiller opened this issue Nov 2, 2011 · 0 comments

Comments

@pfiller
Copy link
Contributor

pfiller commented Nov 2, 2011

As reported in #327, jQuery 1.6 adds the prop() function and makes a change to attr(). When setting properties directly on a DOM element, Chosen should probably move away from either so support can extend across multiple versions of jQuery.

Think

@is_disabled = @form_field_jq[0].disabled

Not

@is_disabled = @form_field_jq.attr "disabled"

There's a good discussion on Stack Overflow regarding this issue:
http://stackoverflow.com/questions/5874652/prop-vs-attr

koenpunt added a commit to koenpunt/chosen that referenced this issue Jul 22, 2013
koenpunt added a commit to koenpunt/chosen that referenced this issue Jul 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant